Skip to content
This repository has been archived by the owner on Jul 31, 2019. It is now read-only.

Add strings needed by Brackets for https://github.com/mozilla/brackets/pull/847 #2389

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Jul 20, 2017

These strings are needed for the change in mozilla/brackets#847

@humphd humphd requested a review from gideonthomas July 20, 2017 18:37
@@ -101,6 +102,10 @@ SAVE_AND_OVERWRITE=Overwrite
DELETE=Delete
BUTTON_YES=Yes
BUTTON_NO=No
# "Use Imported" as in "Use the imported version of this file vs. the existing one"
USE_IMPORTED=Use Imported
# "Use Existing" as in "Use the existing version of this file vs. the imported one"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "Keep Existing" vs. "Use Existing" and "Keep the existing" vs. "Use the existing"

@flukeout
Copy link
Contributor

Should it say, A file with this name already exists. or are we actually checking to see if it's the exact same file? Also, when does this pop up? Whenever you drag in or upload a new file?

We can just say "Keep existing" and "Use new" and ditch "Importing" as a verb.

@humphd humphd force-pushed the strings-for-dnd-overwrite branch from f06535a to 8f2593c Compare July 20, 2017 18:52
@humphd humphd merged commit c6a80c5 into mozilla:master Jul 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants