Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement support for Ed25519 signing #87

Merged
merged 5 commits into from
Oct 31, 2023
Merged

feat: implement support for Ed25519 signing #87

merged 5 commits into from
Oct 31, 2023

Conversation

Erik1000
Copy link
Member

No description provided.

@Erik1000 Erik1000 linked an issue Oct 31, 2023 that may be closed by this pull request
Support curve25519 #11
Closed
@Erik1000 Erik1000 marked this pull request as draft October 31, 2023 14:44
@Erik1000 Erik1000 marked this pull request as ready for review October 31, 2023 14:44
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

Merging #87 (2b25c9d) into main (a8519b6) will increase coverage by 0.5%.
The diff coverage is 50.8%.

Files Coverage Δ
src/jwk/okp/curve25519.rs 100.0% <100.0%> (ø)
src/jwk/private.rs 16.6% <ø> (ø)
src/jwk/public.rs 100.0% <ø> (ø)
src/jwk/okp.rs 12.5% <50.0%> (+12.5%) ⬆️
src/jwk/signer.rs 51.1% <0.0%> (-3.8%) ⬇️
src/jwk/verifier.rs 48.5% <0.0%> (-7.5%) ⬇️
src/jwk/okp/curve25519/ed25519.rs 55.3% <55.3%> (ø)

... and 4 files with indirect coverage changes

@Stupremee Stupremee added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit c215eab Oct 31, 2023
17 of 18 checks passed
@Erik1000 Erik1000 deleted the 11-support-curve25519 branch November 26, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stupremee Stupremee Stupremee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support curve25519
2 participants
@Erik1000 @Stupremee