Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support curve25519 #11

Closed
Erik1000 opened this issue Jul 22, 2022 · 2 comments · Fixed by #87
Closed

Support curve25519 #11

Erik1000 opened this issue Jul 22, 2022 · 2 comments · Fixed by #87
Assignees
Labels
blocked An issue that can't be solved because it depends on something (e.g. a missing library) release:0.1 Issues which must be solved for the 0.1 release

Comments

@Erik1000
Copy link
Member

Erik1000 commented Jul 22, 2022

This issue is blocked, because ed25519-dalek does not allow us to reconstruct a key from its individual points (see the RFC). We'd need to use Keypair::from_bytes and bring the bytes in the correct format which is kind of tricky.

@Erik1000 Erik1000 added blocked An issue that can't be solved because it depends on something (e.g. a missing library) release:0.1 Issues which must be solved for the 0.1 release and removed blocked An issue that can't be solved because it depends on something (e.g. a missing library) labels Aug 5, 2022
@Erik1000 Erik1000 mentioned this issue Aug 5, 2022
21 tasks
@Erik1000 Erik1000 added the blocked An issue that can't be solved because it depends on something (e.g. a missing library) label Aug 5, 2022
@Erik1000
Copy link
Member Author

Erik1000 commented Sep 10, 2022

We are able to use Keypair::from_bytes but ed25519-dalek has outdated dependencies and other ed25519 implementations don't allow us to sign prehashed messages which is needed by our Signer trait. The outdated dependencies of ed25519-dalek (digest to be precise) break the trait bounds of our Signer.

@Erik1000 Erik1000 self-assigned this Jul 27, 2023
@Erik1000
Copy link
Member Author

Now, we can use (SigningKey::sign_prehashed)[https://docs.rs/ed25519-dalek/2.0.0-rc.3/ed25519_dalek/struct.SigningKey.html#method.sign_prehashed] but since this is ed25519*ph* the output is different from ed25519. This however is only because of the context used for domain separation but I think we cannot bypass this.

@Erik1000 Erik1000 linked a pull request Oct 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked An issue that can't be solved because it depends on something (e.g. a missing library) release:0.1 Issues which must be solved for the 0.1 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant