Unable to disable/remap Escape key closing CommentThreadWidget

[mogelbrod]

Type: Bug

This recently merged PR unfortunately partially broke the VSCodeVim comment editor integration (issue) as it added a un-remappable key binding for Escape to close the comment panel. Vim maps Escape to leave whichever mode is currently active, which is no longer possible since the code introduced by the PR gets triggered instead.

Is there a way to re-implement the newly added Escape keybinding using the regular vscode keybinding configuration? This would allow the vim extension to remap it so that it doesn't collide with the vim specific Escape binding.

Steps to reproduce:

1. Open a project in vscode
2. Install the VSCodeVim extension
3. Check out a branch containing PR comments
4. Navigate to a file with PR comment(s)
5. Expand/open the PR comment thread in the editor view
6. Focus on the "Reply..." field to enter the comment editor
7. Press the I key to enter vim insert mode
8. Press the Escape key to leave insert mode

Expected outcome: Comment thread widget stays visible, with vim returning to normal mode
Actual outcome: Comment thread widget is closed

VS Code version: Code 1.94.2 (384ff73, 2024-10-09T16:08:44.566Z)
OS version: Darwin arm64 23.6.0
Modes:

System Info

Item	Value
CPUs	Apple M1 Max (10 x 2400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off
Load (avg)	3, 3, 4
Memory (System)	32.00GB (0.75GB free)
Process Argv	--crash-reporter-id 2a7fc035-033f-461f-92b1-f13bec48ca26
Screen Reader	no
VM	0%

Extensions (4)

Extension	Author (truncated)	Version
vscode-command-inspector	bab	0.0.1
vscode-pull-request-github	Git	0.98.0
quickopener	mog	0.5.0
vim	vsc	1.28.1