Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change the keybinding for workbench.action.hideComment #6377

Closed
forivall opened this issue Oct 23, 2024 · 1 comment
Closed

Cannot change the keybinding for workbench.action.hideComment #6377

forivall opened this issue Oct 23, 2024 · 1 comment

Comments

@forivall
Copy link

forivall commented Oct 23, 2024

This is related to #1455, but it's not strictly a duplicate.

  • Extension version: 0.98.0
  • VSCode Version: 1.94.2
  • OS: Mac OS X 10_15_7 Chrome/130.0.0.0
  • Repository Clone Configuration (single repository/fork of an upstream repository): using github.dev on a pull request
  • Github Product (Github.com/Github Enterprise version x.x.x): github.com / github.dev

Steps to Reproduce:

  1. Add the following to your keybindings.json to disable the escape keybinding for workbench.action.hideComment
{
  "key": "escape",
  "command": "-workbench.action.hideComment",
  "when": "commentEditorFocused"
}
  1. Open a pull request, open a comment
  2. Hit escape
  3. Observe that the comment is hidden.

This is especially frustrating as I use https://github.com/71/dance for helix keybindings (similar to vim), and when i try to hit escape to switch to normal mode inside of a comment editor, the comment editor simply closes.

@alexr00
Copy link
Member

alexr00 commented Oct 24, 2024

Duplicate of microsoft/vscode#231674

@alexr00 alexr00 closed this as completed Oct 24, 2024
@alexr00 alexr00 marked this as a duplicate of microsoft/vscode#231674 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants