Integration with comments broke with recent versions

[Ten0]

Describe the bug

A few releases ago, it became possible to use VSCode Vim when editing comments from the Github Pull Requests extension.
This was absolutely amazing, and game changer when writing comments. (Vim ❤️)

However since a very recent release (of VSCode probably), pressing escape while in insertion mode, instead of returning to normal mode, cancels writing the comment, closes the dialog and discards the text.
In one hour of reviewing PRs, it's the 4th super detailed comment I have to entirely rewrite because it's hardwired in my brain that I can press escape to exit insertion mode, and that actually closes the comment dialog. (So by the way there's no way to exit insertion mode.)
I'm going crazy. 😭
Please help! 🏝️🏳️

Thanks in advance!

To Reproduce
Steps to reproduce the behavior:

1. Install VSCode VIM & Github Pull Requests extension
2. Open a PR
3. Start writing a comment
4. Enter insertion mode and write some text
5. Press escape.

Expected behavior
Exits insertion mode, not closing the dialog.

Environment (please complete the following information):

• Extension (VsCodeVim) version: 1.28.1
• VSCode version: 1.93.0
• Github Pull Requests version: 0.96.0
• OS: Linux

[diminutivesloop]

This should definitely be fixed. Comments can already be closed via shift+escape so escape by itself should be reserved for changing modes. Right now I'm working around this by using ctrl+[ to change modes.

[mogelbrod]

This appears to be an addition to either vscode itself or the Github Pull Requests extension, as Escape closes the comment widget with VSCodeVim disabled. Disabling VSCodeVim, enabling "Developer: Toggle Keyboard Shortcuts Troubleshooting" and then looking at the vscode "Window" output suggests that this is not triggered by a regular keyboard binding since no command is invoked:

2024-10-18 14:07:59.141 [info] [KeybindingService]: / Soft dispatching keyboard event
2024-10-18 14:07:59.141 [info] [KeybindingService]: | Resolving [Escape]
2024-10-18 14:07:59.141 [info] [KeybindingService]: \ From 72 keybinding entries, no when clauses matched the context.
2024-10-18 14:07:59.145 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Escape, keyCode: 27, key: Escape
2024-10-18 14:07:59.145 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Escape, keyCode: 9 ('Escape')
2024-10-18 14:07:59.145 [info] [KeybindingService]: | Resolving [Escape]
2024-10-18 14:07:59.145 [info] [KeybindingService]: \ From 72 keybinding entries, no when clauses matched the context.

[mogelbrod]

Found the underlying issue in vscode and created a ticket: microsoft/vscode#231674