Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[liblzma] Change repo #38037

Closed
wants to merge 2 commits into from
Closed

[liblzma] Change repo #38037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dce9ac5
[liblzma] Change repo
Apr 8, 2024
e2ff393
version
Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ports/liblzma/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
vcpkg_from_github(
vcpkg_from_sourceforge(
OUT_SOURCE_PATH SOURCE_PATH
REPO tukaani-project/xz
REF "v${VERSION}"
SHA512 c28461123562564e030f3f733f078bc4c840e87598d9f4b718d4bca639120d8133f969c45d7bdc62f33f081d789ec0f14a1791fb7da18515682bfe3c0c7362e0
HEAD_REF master
REPO lzmautils
FILENAME "xz-5.4.4.tar.gz"
SHA512 2e27d864c9f346e53afc549d7046385b5d35a749af15d84f69de14612657df2f0e2ce71d3be03d57adadf8fd28549ecf4ef1c214bdcd1f061b5a47239e0104e8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the version number from the variable: "xz-${VERSION}.tar.gz".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's easy to fix, however, the current problem is the SHA512 value changed, which cannot guarantee the source code is same with the origin one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this suggestion is unrelated to the SHA512.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this suggestion is unrelated to the SHA512.

So we need to wait until accept to switch to sourceforge first.

PATCHES
fix_config_include.patch
win_output_name.patch # Fix output name on Windows. Autotool build does not generate lib prefixed libraries on windows.
Expand Down
1 change: 1 addition & 0 deletions ports/liblzma/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "liblzma",
"version": "5.4.4",
"port-version": 1,
"description": "Compression library with an API similar to that of zlib.",
"homepage": "https://tukaani.org/xz/",
"license": null,
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4594,7 +4594,7 @@
},
"liblzma": {
"baseline": "5.4.4",
"port-version": 0
"port-version": 1
},
"libmad": {
"baseline": "0.16.4",
Expand Down
5 changes: 5 additions & 0 deletions versions/l-/liblzma.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "e043f163404466852c9f05a1a06dc03b08cc7eb7",
"version": "5.4.4",
"port-version": 1
},
{
"git-tree": "b362003b452b95b7fef8577175651a7e33940f7f",
"version": "5.6.0",
Expand Down
Loading