Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liblzma] Change repo #38037

Closed
wants to merge 2 commits into from
Closed

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Apr 8, 2024

In order to solve the download failure problem caused by the disabled repo due to the planting of backdoor, replace the repo to sourceforge.

Affected version >=5.6.0, so there is no risk on the vcpkg side.

Thanks @AbdulsalamAmin.

Fixes #37893

@JackBoosY
Copy link
Contributor Author

Related #37957

@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Apr 8, 2024
@JackBoosY
Copy link
Contributor Author

The real problem is SHA512 not matched with the origin one.

@JonLiu1993
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

sparkpunkd added a commit to sparkpunkd/vcpkg that referenced this pull request Apr 9, 2024
SHA512 c28461123562564e030f3f733f078bc4c840e87598d9f4b718d4bca639120d8133f969c45d7bdc62f33f081d789ec0f14a1791fb7da18515682bfe3c0c7362e0
HEAD_REF master
REPO lzmautils
FILENAME "xz-5.4.4.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use the version number from the variable: "xz-${VERSION}.tar.gz".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's easy to fix, however, the current problem is the SHA512 value changed, which cannot guarantee the source code is same with the origin one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this suggestion is unrelated to the SHA512.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this suggestion is unrelated to the SHA512.

So we need to wait until accept to switch to sourceforge first.

@talregev
Copy link
Contributor

talregev commented Apr 9, 2024

@JackBoosY
You can change it to this if you don't want to change the hash.
https://github.com/xz-mirror/xz

Also
The original is here:
https://git.tukaani.org/?p=xz.git;a=summary

But I think it not the same hash.

@BillyONeal
Copy link
Member

Thanks for the workaround attempt :)

See #37841 (comment) : the repo should be public again.

@BillyONeal BillyONeal closed this Apr 9, 2024
@JackBoosY JackBoosY deleted the jack/37893 branch April 10, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[liblzma] Unable to download "xz" caused install falied
6 participants