Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LXML CI build break #195

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Fix LXML CI build break #195

merged 2 commits into from
Apr 1, 2024

Conversation

ghidalgo3
Copy link
Contributor

Description

We didn't pin LXML and over the weekend a breaking change was released.

Fixes #194

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tested.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@ghidalgo3 ghidalgo3 marked this pull request as ready for review April 1, 2024 14:17
@ghidalgo3 ghidalgo3 mentioned this pull request Apr 1, 2024
Merged
3 tasks
@ghidalgo3 ghidalgo3 merged commit 8436378 into main Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcfarland mmcfarland mmcfarland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI build break due to unpinned lxml version
2 participants
@ghidalgo3 @mmcfarland