Remove BaseHTTPMiddlewares , Ensure origin host is used in STAC links #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
performance with main |
TomAugspurger
approved these changes
Mar 28, 2024
pctiler/pctiler/main.py
Outdated
| return await handle_exceptions(request, call_next) | ||
|
|
||
|
|
||
| app.add_exception_handler(Exception, http_exception_handler) |
There was a problem hiding this comment.
Can you confirm that if you make an invalid POST request (like bad data) we still get the nice error message? I couldn't quickly confirm what the behavior of app.add_exception_handler is with Exception subclasses / order. I see that we reraise HTTPException in our handler, and just want to make sure FastAPI's still handles it.
There was a problem hiding this comment.
okie so this is an instance of internal server error
There was a problem hiding this comment.
this is 404 collection not found
ghidalgo3
approved these changes
Mar 28, 2024
|
Also taking a look at this. |
mmcfarland
reviewed
Mar 28, 2024
mmcfarland
reviewed
Mar 28, 2024
mmcfarland
reviewed
Mar 28, 2024
|
You will need #195 to fix the CI build |
mmcfarland
reviewed
Apr 9, 2024
mmcfarland
reviewed
Apr 10, 2024
mmcfarland
reviewed
Apr 11, 2024
mmcfarland
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing BaseHTTPMiddleware to improve performance. Re-implementation of timeout middleware and error handling middleware replaced by registering exception handlers with the app. Reimplementation of trace middleware by calling the tracing function directly instead of using a BaseHTTPMiddleware .
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I ran ./scripts/test
Checklist:
Please delete options that are not relevant.