Use Key Vault secrets instead of cert-manager secret in AKS cluster #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Looks good overall.
For the jsonschema stuff, I think you'll need to either upgrade pystac or pin jsonschema. See stac-utils/pystac#1186 and linked issues.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can no longer use cert-manager and instead the TLS certificate used by the cluster for HTTPS calls must come from a key vault and be made available in the NGINX pods. The certificates were created manually, the changes in this PR are to update AKS to be able to use Key Vault certificates in pods.
There is some unexplained behavior with the NGINX ingress controller where it would not match hosts to TLS certs correctly and the only way to make the ingress controller use the correct cert was to set it as the default. This is not desirable, but it is working and one day will be fixed.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Deployed to planetarycomputer-test.microsoft.com.
Checklist:
Please delete options that are not relevant.