Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Key Vault secret provider for TLS certificates #292

Merged
merged 10 commits into from
May 15, 2024

Conversation

ghidalgo3
Copy link
Contributor

Description

Similar to microsoft/planetary-computer-apis#185, this change modifies the Helm chart, Terraform, and ingress for PCTasks to use Key Vault certificates instead of cert-manager managed certificates.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I deployed the test PCTasks environment and saw that the ingress came up with the changes.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Documentation has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@ghidalgo3 ghidalgo3 marked this pull request as ready for review May 15, 2024 16:09
@ghidalgo3 ghidalgo3 merged commit e767706 into main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants