-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing "IRC" with "Chat" or "ChatBrainz" #485
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,22 +87,31 @@ <h3>{{ _('Forums') }}</h3> | |
answer any questions you may have.', forums_url='https://community.metabrainz.org/') }} | ||
</p> | ||
|
||
<h3>{{ _('IRC') }}</h3> | ||
<h3>{{ _('Chat') }}</h3> | ||
<p> | ||
{{ _('The MetaBrainz/MusicBrainz team, as well as MusicBrainz supporters, hang out in the | ||
<strong><a href="%(irc_url_mb)s">#musicbrainz</a></strong> and | ||
<strong><a href="%(irc_url_meb)s">#metabrainz</a></strong> | ||
channels on IRC chat at irc.libera.chat. If you don\'t have an IRC client | ||
installed, consider using this | ||
<a href="%(irc_webchat_url)s">webchat client</a> | ||
instead. Please feel free to browse the | ||
<a href="%(chatlogs_url)s">IRC log archives</a>.', | ||
{{ _('The MetaBrainz/MusicBrainz/ListenBrainz team and community hang out | ||
on our Matrix, IRC and Discord channels. Visit the | ||
<a href="https://musicbrainz.org/doc/Communication/ChatBrainz">ChatBrainz</a> | ||
page and join the chat. You can also browse the | ||
<a href="%(chatlogs_url)s">chat log archives</a>.', | ||
irc_url_mb='ircs://irc.libera.chat:6697/musicbrainz', | ||
irc_url_meb='ircs://irc.libera.chat:6697/metabrainz', | ||
irc_webchat_url='https://kiwiirc.com/nextclient/irc.libera.chat/#musicbrainz,#metabrainz', | ||
Comment on lines
97
to
99
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These URLs should probably be removed since they're no longer used. And the ChatBrainz one should probably be used in a similar way as these were rather than just pasting it as-is inside the string. |
||
chatlogs_url='http://chatlogs.metabrainz.org/') }} | ||
</p> | ||
|
||
<h3>{{ _('Social Media') }}</h3> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We use sentence case for other headers. |
||
<p> | ||
{{ _('Nobody\'s perfect. You can follow us on these social channels:') }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe use a proper apostrophe and then you don't need to escape it ;) Although I'm not sure why the "Nobody's perfect" bit is there anyway? 😅 |
||
<ul> | ||
<li>{{ _('<a href="https://blog.metabrainz.org/">Blog</a>') }}</li> | ||
<li>{{ _('<a href="https://x.com/MetaBrainz">Twitter/X</a>') }}</li> | ||
<li>{{ _('<a href="https://mastodon.social/@metabrainz">Mastodon</a>') }}</li> | ||
<li>{{ _('<a href="https://bsky.app/profile/metabrainz.org">Bluesky</a>') }}</li> | ||
<li>{{ _('<a href="https://www.instagram.com/MetaBrainz/">Instagram</a>') }}</li> | ||
Comment on lines
+107
to
+111
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ideally these should also be done with variables such as Alternatively (and possibly even better?) you could just take the URL bit out of the translatable bit and leave just the title, since that seems to be what we already do in the footer? |
||
</ul> | ||
</p> | ||
|
||
<h3>{{ _('Mailing address') }}</h3> | ||
<p> | ||
MetaBrainz Foundation<br/> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you do the
messages.pot
changes by hand? I assume the.pot
file is automatically generated by some script and we should run that instead.