Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing "IRC" with "Chat" or "ChatBrainz" #485

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Aerozol
Copy link
Contributor

@Aerozol Aerozol commented Oct 6, 2024

As mentioned by mayhem at the summit, updated "IRC" references to "Chat" or "ChatBrainz" references and changed the relevant links.

Will need testing, sorry, but hopefully this is most of the work done.

As mentioned by mayhem at the summit, updated IRC references to ChatBrainz references and changed the relevant links.

Also added a social media section, as they are in the footer and why not. Blog doesn't 100% fit the header, but I think this is the best place for it.
I think Chat is a big enough MeB channel to be in the footer for 'Contact Us', especially compared to Insta etc.
Now that we have team members spread across a few chat channels (Mainly Matrix and IRC) I have changed references to "IRC" to the hopefully-future proof "Chat"
Replaced "IRC" with "chat"/"ChatBrainz" as appropriate.
Replaced "IRC" with "Chat"
@mayhem
Copy link
Member

mayhem commented Oct 9, 2024

Hey, thanks for tackling this. I'll pay attention to it once the back-to-aback summits have stopped their toll on me.

@Aerozol
Copy link
Contributor Author

Aerozol commented Oct 9, 2024

No rush, take it easy!

Comment on lines 97 to 99
irc_url_mb='ircs://irc.libera.chat:6697/musicbrainz',
irc_url_meb='ircs://irc.libera.chat:6697/metabrainz',
irc_webchat_url='https://kiwiirc.com/nextclient/irc.libera.chat/#musicbrainz,#metabrainz',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These URLs should probably be removed since they're no longer used. And the ChatBrainz one should probably be used in a similar way as these were rather than just pasting it as-is inside the string.

irc_url_mb='ircs://irc.libera.chat:6697/musicbrainz',
irc_url_meb='ircs://irc.libera.chat:6697/metabrainz',
irc_webchat_url='https://kiwiirc.com/nextclient/irc.libera.chat/#musicbrainz,#metabrainz',
chatlogs_url='http://chatlogs.metabrainz.org/') }}
</p>

<h3>{{ _('Social Media') }}</h3>
<p>
{{ _('Nobody\'s perfect. You can follow us on these social channels:') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a proper apostrophe and then you don't need to escape it ;) Although I'm not sure why the "Nobody's perfect" bit is there anyway? 😅

irc_url_mb='ircs://irc.libera.chat:6697/musicbrainz',
irc_url_meb='ircs://irc.libera.chat:6697/metabrainz',
irc_webchat_url='https://kiwiirc.com/nextclient/irc.libera.chat/#musicbrainz,#metabrainz',
chatlogs_url='http://chatlogs.metabrainz.org/') }}
</p>

<h3>{{ _('Social Media') }}</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use sentence case for other headers.

Comment on lines +107 to +111
<li>{{ _('<a href="https://blog.metabrainz.org/">Blog</a>') }}</li>
<li>{{ _('<a href="https://x.com/MetaBrainz">Twitter/X</a>') }}</li>
<li>{{ _('<a href="https://mastodon.social/@metabrainz">Mastodon</a>') }}</li>
<li>{{ _('<a href="https://bsky.app/profile/metabrainz.org">Bluesky</a>') }}</li>
<li>{{ _('<a href="https://www.instagram.com/MetaBrainz/">Instagram</a>') }}</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally these should also be done with variables such as blog_url, mastodon_url, etc - that way if the URL changes later (say, because some idiot buys Bluesky and renames it Y) it won't change the actual string translators will see.

Alternatively (and possibly even better?) you could just take the URL bit out of the translatable bit and leave just the title, since that seems to be what we already do in the footer?

@@ -1069,7 +1065,7 @@ msgstr ""
msgid ""
"Hired in the fall of 2015 as the MetaBrainz Community Manager, Freso is "
"in charge of most of the public communication\n"
" channels (IRC, forums, blog, etc.) and various community "
" channels (Chat, forums, blog, etc.) and various community "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do the messages.pot changes by hand? I assume the .pot file is automatically generated by some script and we should run that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants