Test 'test_models_paper' fails in branch split_mros1_reasoner #98
Comments
|
After some fixes in a5256fc There is still an error that I do not understand, because it relates to [WARN] [1600242183.260293]: Objectives in status ERROR: ['o_navigateA']
[WARN] [1600242183.265628]: New Configuration requested: f1_v1_r2
Exception in thread Thread-4:
Traceback (most recent call last):
File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
self.run()
File "/opt/ros/melodic/lib/python2.7/dist-packages/rospy/timer.py", line 234, in run
self._callback(TimerEvent(last_expected, last_real, current_expected, current_real, last_duration))
File "/home/parallels/tests_mros_reasoner_ws/src/mros1_reasoner/mros1_reasoner/scripts/mros1_reasoner.py", line 209, in timer_cb
result = request_configuration(fd)
File "/home/parallels/tests_mros_reasoner_ws/src/mros1_reasoner/mros1_reasoner/scripts/mros1_reasoner.py", line 232, in request_configuration
result = rosgraph_manipulator_client.get_result().result
AttributeError: 'NoneType' object has no attribute 'result'
[Testcase: testtest_models_paper] ... ok
[ROSTEST]-----------------------------------------------------------------------
[mros1_reasoner.rosunit-test_models_paper/test_one_equals_one][passed]
[mros1_reasoner.rosunit-test_models_paper/test_publish_energy_qa_value][passed]
[mros1_reasoner.rosunit-test_models_paper/test_publish_safety_qa_value][FAILURE]
False is not true
File "/usr/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
yield
File "/usr/lib/python3.6/unittest/case.py", line 605, in run
testMethod()
File "/home/parallels/tests_mros_reasoner_ws/src/mros1_reasoner/mros1_reasoner/test/test_models_paper.py", line 125, in test_publish_safety_qa_value
self.assert_(self.success)
File "/usr/lib/python3.6/unittest/case.py", line 1321, in deprecated_func
return original_func(*args, **kwargs)
File "/usr/lib/python3.6/unittest/case.py", line 682, in assertTrue
raise self.failureException(msg)
--------------------------------------------------------------------------------
SUMMARY
* RESULT: FAIL
* TESTS: 3
* ERRORS: 0
* FAILURES: 1 |
|
For me the test is passing. So I'm just guessing here.
It may be that this is trying to access the result before it's there, so it may be a timing issue. We can check that it's not |
|
Looks indeed a timing issue. Now I got the test SUCCEED, but I keep the same exception when the reconfiguration is requested: [WARN] [1600286684.060666]: Objectives in status ERROR: ['o_navigateA']
[WARN] [1600286684.065911]: New Configuration requested: f1_v1_r2
Exception in thread Thread-4:
Traceback (most recent call last):
File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
self.run()
File "/opt/ros/melodic/lib/python2.7/dist-packages/rospy/timer.py", line 234, in run
self._callback(TimerEvent(last_expected, last_real, current_expected, current_real, last_duration))
File "/home/parallels/tests_mros_reasoner_ws/src/mros1_reasoner/mros1_reasoner/scripts/mros1_reasoner.py", line 209, in timer_cb
result = request_configuration(fd)
File "/home/parallels/tests_mros_reasoner_ws/src/mros1_reasoner/mros1_reasoner/scripts/mros1_reasoner.py", line 232, in request_configuration
result = rosgraph_manipulator_client.get_result().result
AttributeError: 'NoneType' object has no attribute 'result'
[Testcase: testtest_models_paper] ... ok
[ROSTEST]-----------------------------------------------------------------------
[mros1_reasoner.rosunit-test_models_paper/test_one_equals_one][passed]
[mros1_reasoner.rosunit-test_models_paper/test_publish_energy_qa_value][passed]
[mros1_reasoner.rosunit-test_models_paper/test_publish_safety_qa_value][passed]
SUMMARY
* RESULT: SUCCESS
* TESTS: 3
* ERRORS: 0
* FAILURES: 0
rostest log file is in /home/parallels/.ros/log/rostest-parallelsu18-30348.log` |
|
I think I know what the problem is: Sometimes there is a second reconfiguration, and that one is failing, probably because we are not handling properly the new grounding and related name of the configuration for the |
This just avoids the program to break with an error when the connection to the action_server is lost, as related in #98 Still need to find out why it's been lost in the first place
|
Update: This is still happening from time to time. Seems that the issue is that the connection to the action server is lost. I've added a check on 85a0f0a to avoid the crash, but still don't know how to avoid losing the connection. Also, each time it fails I'm getting this warning So it's definitely related to ros_comm |
@marioney can you confirm is it happens when there is a 2nd reconfiguration action requested? |
Yes, I think it happens always on the second reconfiguration action. At least I haven't seen it fail on the first one. |
This just avoids the program to break with an error when the connection to the action_server is lost, as related in #98 Still need to find out why it's been lost in the first place
A similar issue to #97. I forgot to try this test before merging.
I am looking into it. Probably test conditions in rosout have changed.
This is the output I get went things go "wrong"
The text was updated successfully, but these errors were encountered: