Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: PyPy does not use a special filename suffix for the stable API #494

Merged
merged 1 commit into from
Sep 10, 2023
Merged

BUG: PyPy does not use a special filename suffix for the stable API #494

merged 1 commit into from
Sep 10, 2023

Conversation

dnicolodi
Copy link
Member

No description provided.

@rgommers rgommers added the bug Something isn't working label Sep 10, 2023
rgommers
rgommers reviewed Sep 10, 2023
View reviewed changes
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnicolodi. How did you notice this, in local testing or did we receive a bug report somewhere? And related question: we have a pypy-3.9 CI job, why didn't it fail before?

mesonpy/__init__.py Outdated Show resolved Hide resolved
mesonpy/__init__.py Outdated Show resolved Hide resolved
@dnicolodi
Copy link
Member Author

How did you notice this, in local testing or did we receive a bug report somewhere? And related question: we have a pypy-3.9 CI job, why didn't it fail before?

It is a bi-product of #492 where I run the meson-python test suite on all environments with Meson from a branch close to master to test the changes required in Meson to get rid of the distutils dependency. The limited API feature requires an unreleased Meson version, and the PyPy CI job we have uses the latest Meson release, thus could not catch the issue.

@dnicolodi dnicolodi mentioned this pull request Sep 10, 2023
Merged
@rgommers rgommers added this to the v0.15.0 milestone Sep 10, 2023
rgommers
rgommers approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now.

@rgommers rgommers merged commit b4d4240 into mesonbuild:main Sep 10, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dnicolodi @rgommers