-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: bump minimum required Meson version on Python 3.12 #492
Conversation
86e0b08
to
e5e8ffa
Compare
5988d25
to
b99ec1a
Compare
distutils
dependency when using Python 3.12
distutils
dependency when using Python 3.12distutils
dependency when using Python 3.12
distutils
dependency when using Python 3.12distutils
dependency when running Python 3.12
The meson branch works as advertised, |
b99ec1a
to
d262239
Compare
5bf5454
to
128a213
Compare
16ad7fd
to
31f1e5b
Compare
31f1e5b
to
94cd2b2
Compare
The required change to drop the use of dependencies = [
'colorama; os_name == "nt"',
'meson >= 0.63.3; python_version < "3.12"',
'meson >= 1.2.3; python_version >= "3.12"',
'pyproject-metadata >= 0.7.1',
'tomli >= 1.0.0; python_version < "3.11"',
] This has the drawback to require a very recent (at the moment not yet released) version of meson on Python 3.12. I don't know whether this may be an issue in practice. Of course we can do this only when a suitable meson version is actually released. |
Changing to |
99b376a
to
2f8bd53
Compare
2f8bd53
to
ef2b4ec
Compare
Cython 3.0.3 does not require distutils and thus works on Python 3.12 without having to install setuptools.
Require a Meson version that does not rely on distutils when operating on Python 3.12 where the distutils module has been removed. This allows to remove the conditional setuptools dependency on Python 3.12.
ef2b4ec
to
0170442
Compare
distutils
dependency when running Python 3.12
Meson 1.2.3 has been released dropping the requirement for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This all LGTM, in it goes. Thanks @dnicolodi!
No description provided.