Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support URL CEL library #244

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Support URL CEL library #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
75b1a21
✨ impl net/url.Parse
pikachu0310 Sep 4, 2024
ebbbf3d
✨ impl URL and Useinfo functions
pikachu0310 Sep 6, 2024
122a210
✨ impl remaining functions
pikachu0310 Sep 13, 2024
71a5688
✅ add url tests
pikachu0310 Sep 17, 2024
62e1747
🐛 fix some functions
pikachu0310 Sep 25, 2024
334e23a
✅ add remaining tests
pikachu0310 Sep 25, 2024
7b5b20b
📝 add url.md
pikachu0310 Sep 26, 2024
3a23f78
🚨 fix lint
pikachu0310 Sep 26, 2024
3279e04
🐛 fix some logic
pikachu0310 Sep 30, 2024
a524494
🐛 fix conflict
pikachu0310 Sep 30, 2024
2ce32a6
🎨 removed unnecessary error return
pikachu0310 Oct 1, 2024
38a3d88
🎨 URL handling to use lib.refToGoURLValue
pikachu0310 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
413 changes: 215 additions & 198 deletions _examples/02_simple/federation/federation.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

145 changes: 94 additions & 51 deletions _examples/02_simple/federation/federation_grpc_federation.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions _examples/02_simple/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ func TestFederation(t *testing.T) {
if err != nil {
t.Fatal(err)
}

if diff := cmp.Diff(res, &federation.GetPostResponse{
Post: &federation.Post{
Id: "foo",
Expand Down Expand Up @@ -317,6 +318,7 @@ func TestFederation(t *testing.T) {
NullTimestamp3: nil,
JpLoc: "JST",
StringsJoin: "a,b,c",
UrlUserName: "test_user",
}, cmpopts.IgnoreUnexported(
federation.GetPostResponse{},
federation.Post{},
Expand Down
2 changes: 2 additions & 0 deletions _examples/02_simple/proto/federation/federation.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ message GetPostResponse {
}
}
def { name: "strings_join" by: "grpc.federation.strings.join(['a', 'b', 'c'], ',')" }
def { name: "url" by: "grpc.federation.url.parse('https://test_user:[email protected]/path')" }
def { name: "date" by: "grpc.federation.time.date(2023, 12, 25, 12, 10, 5, 0, grpc.federation.time.UTC())" }
def { name: "rand_source" by: "grpc.federation.rand.newSource(date.unix())" }
def { name: "fixed_rand" by: "grpc.federation.rand.new(rand_source)" }
Expand Down Expand Up @@ -78,6 +79,7 @@ message GetPostResponse {
google.protobuf.Timestamp null_timestamp3 = 30 [(grpc.federation.field).by = "true ? null : google.protobuf.Timestamp{}"];
string jp_loc = 31 [(grpc.federation.field).by = "jp_time.location().string()"];
string strings_join = 32 [(grpc.federation.field).by = "strings_join"];
string url_user_name = 33 [(grpc.federation.field).by = "url.userinfo().username()"];
}

message A {
Expand Down
Loading
Loading