-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support URL CEL library #244
Conversation
2d15b60
to
030f536
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, so PTAL 🙏
e811a9d
to
a524494
Compare
This comment has been minimized.
This comment has been minimized.
I have addressed ktgw's review comments and resolved the conflicts. Please review it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments so PTAL 🙏
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙆♂️
also lib.refToGoUserinfoValue
Code Metrics Report
Details | | main (e478944) | #244 (4e0c688) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 66.0% | 66.3% | +0.3% |
| Files | 75 | 76 | +1 |
| Lines | 12418 | 12557 | +139 |
+ | Covered | 8192 | 8320 | +128 |
+ | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 |
| Code | 38524 | 39019 | +495 |
+ | Test | 13878 | 14665 | +787 |
+ | Test Execution Time | 7m55s | 7m45s | -10s | Code coverage of files in pull request scope (100.0% → 93.0%)
Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Support strconv CEL library #244
Provide functionalities similar to Go's net/url using the grpc.federation.url library.