-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support selecting zaaktype from list in filter in destruct… #36
Merged
svenvandescheur
merged 1 commit into
main
from
feature/show-zaaktypen-as-options-in-filter
May 17, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { request } from "./request"; | ||
|
||
export type ZaaktypeChoice = { | ||
/** The description field of the zaaktype. */ | ||
label: string; | ||
|
||
/** The URL field of the zaaktype. */ | ||
value: string; | ||
|
||
/** A combination of the identification and the date on which the zaaktype will no longer be valid (if present). */ | ||
extra: string; | ||
}; | ||
|
||
/** | ||
* Retrieve zaaktypen from Open Zaak and return a value and a label per zaaktype. The label is the 'omschrijving' field | ||
* an the value is the URL. The response is cached for 15 minutes. | ||
*/ | ||
export async function listZaaktypeChoices() { | ||
const response = await request("GET", "/_zaaktypen-choices"); | ||
const promise: Promise<ZaaktypeChoice[]> = response.json(); | ||
return promise; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the old version, the query params used here were:
We also wanted the already used zaken to be filtered out, so the param
not_in_destruction_list
should be used. Not sure if this was already taken into account, so I thought that I would mention it 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SilviaAmAm nice catch, this was indeed left out. I've added this line to introduce it:
searchParams.set("not_in_destruction_list", "true");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets discuss the other fields later on (and possibly create and issue out of it). I'll merge this to support ongoing efforts.