✨ Support selecting zaaktype from list in filter in destruct… #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilviaAmAm
reviewed
May 17, 2024
| }); | ||
| export const destructionListCreateLoader = loginRequired( | ||
| async ({ request }) => { | ||
| const searchParams = new URL(request.url).searchParams; |
There was a problem hiding this comment.
In the old version, the query params used here were:
'archiefnominatie': 'vernietigen',
'archiefactiedatum__lt': currentDate,
We also wanted the already used zaken to be filtered out, so the param not_in_destruction_list should be used. Not sure if this was already taken into account, so I thought that I would mention it 😄
There was a problem hiding this comment.
@SilviaAmAm nice catch, this was indeed left out. I've added this line to introduce it:
searchParams.set("not_in_destruction_list", "true");
There was a problem hiding this comment.
Lets discuss the other fields later on (and possibly create and issue out of it). I'll merge this to support ongoing efforts.
Xaohs
approved these changes
May 17, 2024
svenvandescheur
force-pushed
the
feature/show-zaaktypen-as-options-in-filter
branch
from
13aa4ea
to
3739140
Compare
svenvandescheur
force-pushed
the
feature/show-zaaktypen-as-options-in-filter
branch
from
3739140
to
e157d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion list create page