Feature/upgrade django version #341
Conversation
ErhanCitil
force-pushed
the
feature/upgrade-django-version
branch
from
e4bef3c
to
9040bbf
Compare
requirements/base.in
Outdated
| @@ -8,31 +8,33 @@ python-decouple # processing of envvar configs | |||
| jsonschema | |||
|
|
|||
| # Framework libraries | |||
| django < 3.0 | |||
| django==3.2 | |||
There was a problem hiding this comment.
Please remove all pinned versions from base.in file. We pin dependencies in base.txt
package.json
Outdated
| @@ -20,6 +20,7 @@ | |||
| "homepage": "https://maykinmedia.nl", | |||
| "dependencies": { | |||
| "microscope-sass": "latest", | |||
| "prettier": "^2.8.8", | |||
There was a problem hiding this comment.
Why have you added prettier?
| @@ -8,7 +8,6 @@ | |||
|
|
|||
|
|
|||
| class Migration(migrations.Migration): | |||
|
|
|||
There was a problem hiding this comment.
Please in the future make a separate PR for linting. And feel free to merge it, because it doesn't affect the code
Now it's very hard to review
|
|
||
| from .models import User | ||
|
|
||
|
|
||
| @admin.register(User) | ||
| class _UserAdmin(UserAdmin, HijackUserAdminMixin): | ||
| list_display = UserAdmin.list_display + ("hijack_field",) | ||
| list_display = UserAdmin.list_display + ("is_active", "is_staff", "is_superuser") |
There was a problem hiding this comment.
Is there a reason to add these fields in the list view?
There was a problem hiding this comment.
No there is no reason, I can remove it if it's not necessary
src/objects/conf/base.py
Outdated
| @@ -73,7 +73,7 @@ | |||
| "sniplates", | |||
| "hijack", | |||
| "compat", # Part of hijack | |||
| "hijack_admin", | |||
| # "hijack_admin", | |||
There was a problem hiding this comment.
Please remove the line it if it's not used
| "vng_api_common.middleware.AuthMiddleware", | ||
| "vng_api_common.middleware.APIVersionHeaderMiddleware", |
There was a problem hiding this comment.
Why are they added here?
There was a problem hiding this comment.
In the documentation it says that I need to add these middleware:
src/objects/conf/base.py
Outdated
| AXES_USE_USER_AGENT = True # Default: False | ||
| AXES_LOCK_OUT_BY_COMBINATION_USER_AND_IP = True # Default: False | ||
| AXES_LOCKOUT_PARAMETERS = [["ip_address", "user_agent"]] | ||
| AXES_LOCKOUT_PARAMETERS = [["username", "ip_address"]] |
There was a problem hiding this comment.
Two lines for one parameter
| # If set, specifies a template to render when a user is locked out. Template | ||
| # receives cooloff_time and failure_limit as context variables. Default: None | ||
| AXES_LOCKOUT_TEMPLATE = "account_blocked.html" | ||
| AXES_USE_USER_AGENT = True # Default: False | ||
| AXES_LOCK_OUT_BY_COMBINATION_USER_AND_IP = True # Default: False |
There was a problem hiding this comment.
Why have you decided to change it?
There was a problem hiding this comment.
From Django Axes 6.0.0 these settings were deprecated:
src/objects/conf/base.py
Outdated
| PRIVATE_MEDIA_ROOT = os.path.join(BASE_DIR, "private-media") | ||
| PRIVATE_MEDIA_URL = "/private-media/" |
There was a problem hiding this comment.
Why do you need it? I don't remember that Objects API stores user documents
ErhanCitil
force-pushed
the
feature/upgrade-django-version
branch
13 times, most recently
from
d589089
to
7d86a57
Compare
ErhanCitil
force-pushed
the
feature/upgrade-django-version
branch
from
3e4af61
to
e8fc6ef
Compare
No description provided.