Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#322] Show objects data as JSON in the admin interface. #331

Closed
wants to merge 1 commit into from
Closed

[#322] Show objects data as JSON in the admin interface. #331

wants to merge 1 commit into from

Conversation

ErhanCitil
Copy link
Contributor

@ErhanCitil ErhanCitil commented May 19, 2023 •
edited
Loading

fixes #322

afbeelding

@ErhanCitil ErhanCitil requested a review from alextreme May 19, 2023 08:06
@ErhanCitil ErhanCitil linked an issue May 19, 2023 that may be closed by this pull request
Objects API admin: Show Object data as JSON #322
Closed
@joeribekker joeribekker requested review from annashamray and removed request for alextreme May 19, 2023 10:23
@ErhanCitil ErhanCitil self-assigned this May 19, 2023
@ErhanCitil ErhanCitil requested review from alextreme and removed request for alextreme May 19, 2023 10:28
@ErhanCitil ErhanCitil changed the title Show objects data as JSON in the admin interface. [#322] Show objects data as JSON in the admin interface. May 19, 2023
alextreme
alextreme reviewed Jun 1, 2023
View reviewed changes
src/objects/core/admin.py Outdated Show resolved Hide resolved
alextreme
alextreme reviewed Jun 1, 2023
View reviewed changes
src/objects/core/tests/test_models.py Outdated
from .factories import ObjectRecordFactory


class ObjectRecordTestCase(TestCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onnodige test, deze mag weg. In plaats daarvan graag in test_admin.py een test toevoegen waarmee een object in de admin wordt opgevraagd, om te controleren of the output daarvan de JSON-output bevat van object.data

@ErhanCitil
Copy link
Contributor Author

@alextreme eindelijk groen!

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023 •
edited
Loading

Codecov Report

Merging #331 (cacf619) into master (55fbbee) will decrease coverage by 0.10%.
The diff coverage is 84.61%.

❗ Current head cacf619 differs from pull request most recent head 47fb090. Consider uploading reports for the commit 47fb090 to get more accurate results

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   94.78%   94.68%   -0.10%     
==========================================
  Files         131      132       +1     
  Lines        4543     4576      +33     
==========================================
+ Hits         4306     4333      +27     
- Misses        237      243       +6
Impacted Files Coverage Δ
src/objects/accounts/migrations/0001_initial.py 100.00% <ø> (ø)
...cts/accounts/migrations/0002_auto_20201012_1522.py 100.00% <ø> (ø)
...cts/accounts/migrations/0003_auto_20201223_1231.py 100.00% <ø> (ø)
src/objects/api/validators.py 94.02% <ø> (ø)
src/objects/conf/base.py 93.25% <ø> (ø)
src/objects/core/migrations/0001_initial.py 100.00% <ø> (ø)
...objects/core/migrations/0002_auto_20200518_1707.py 100.00% <ø> (ø)
src/objects/core/migrations/0003_objectrecord.py 100.00% <ø> (ø)
...bjects/core/migrations/0004_move_data_to_record.py 62.50% <ø> (ø)
...objects/core/migrations/0005_remove_object_data.py 100.00% <ø> (ø)
... and 35 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme
Copy link
Member

@ErhanCitil hiervoor zouden geen additionele relaties nodig zijn in token/models.py https://github.com/maykinmedia/objects-api/pull/331/files#diff-539f45b9dfaed2de7f65e9a75a243d0b1bf347c77cc802b2888fc0bf57dd110e

@ErhanCitil
Copy link
Contributor Author

@alextreme deze kan ook nagekeken worden

@alextreme
Copy link
Member

Deze en je andere Objecten API PR's moeten qua commits en volgordelijkheid opgeschoond worden voordat ze gemerged kunnen worden. Kom morgen op de lijn bij Joeri zodra je het rebasen een beetje onder de knie hebt.

@ErhanCitil ErhanCitil force-pushed the feature/objects-as-json branch 2 times, most recently from f56afed to 1ff4c51 Compare June 29, 2023 09:04
@ErhanCitil
Copy link
Contributor Author

@alextreme rebase voltooid

alextreme
alextreme reviewed Jun 29, 2023
View reviewed changes
src/objects/token/migrations/0009_auto_20230519_1105.py Outdated
@@ -0,0 +1,34 @@
# Generated by Django 2.2.28 on 2023-05-19 09:05
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this migration

alextreme
alextreme reviewed Jun 29, 2023
View reviewed changes
src/objects/token/migrations/0010_auto_20230612_1015.py Outdated
@@ -0,0 +1,20 @@
# Generated by Django 2.2.28 on 2023-06-12 08:15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this migration

@annashamray
Copy link
Collaborator

It's hard to say but it looks like this PR includes changes from PR #341

I'll review it when the PR with dependencies and linting is merged and this one is rebased on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray Awaiting requested review from annashamray

@alextreme alextreme Awaiting requested review from alextreme

Assignees

@ErhanCitil ErhanCitil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Objects API admin: Show Object data as JSON
5 participants
@ErhanCitil @codecov-commenter @alextreme @annashamray @bart-maykin