Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions 上で型検査する #39

Merged
merged 5 commits into from
Sep 24, 2021
Merged

GitHub Actions 上で型検査する #39

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3756671
ci: run type check on GitHub Actions
mashabow Sep 24, 2021
ca5aea5
chore: remove @types/jest, in favor of @jest/globals
mashabow Sep 24, 2021
8ef881d
try
mashabow Sep 24, 2021
734cd08
Revert "try"
mashabow Sep 24, 2021
fd51a1f
chore: add an npm script to check types
mashabow Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/src/slack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const createSlackApp = (
});
// 型定義上は optional だが、正常系では必ず存在するはず
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
return json.members!.reduce<Record<string, string>>(
return json.members.reduce<Record<string, string>>(
Copy link
Owner Author

@mashabow mashabow Sep 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

試しに変更してみたら PR の diff view に annotation が付いた。

GitHub_Actions_上で型検査する_by_mashabow_·_Pull_Request__39_·_mashabow_slack-rota

https://github.com/mashabow/slack-rota/pull/39/files/ca5aea5912b9d89a5996ff0f84036ec1bbde5149..8ef881df6224d78dd78069a9c8ddcd2c1d418fb6#diff-d7add22db7e289142aea1a04d5d5ea6e8f9d2c1e9b31d3189a29d42e5860c299

どこのトークンでエラーになっているのかが表示されないので、そこが若干微妙…

(acc, { id, profile }) => ({
...acc,
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
Expand Down