Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions 上で型検査する #39

Merged
merged 5 commits into from
Sep 24, 2021
Merged

GitHub Actions 上で型検査する #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3756671
ci: run type check on GitHub Actions
mashabow Sep 24, 2021
ca5aea5
chore: remove @types/jest, in favor of @jest/globals
mashabow Sep 24, 2021
8ef881d
try
mashabow Sep 24, 2021
734cd08
Revert "try"
mashabow Sep 24, 2021
fd51a1f
chore: add an npm script to check types
mashabow Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ jobs:
node-version: "14.x"
- run: npm ci
- run: npm run lint:ci
- name: Type check
uses: gozala/[email protected]
with:
project: functions/tsconfig.json
- name: Create serviceAccountKey.json for online testing
run: echo "$SERVICE_ACCOUNT_KEY_JSON" > ../serviceAccountKey.json
env:
Expand Down
208 changes: 0 additions & 208 deletions functions/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"logs": "firebase functions:log",
"lint": "eslint --format codeframe --ext .js,.jsx,.ts,.tsx .",
"lint:ci": "npm run lint -- --max-warnings=0",
"type": "tsc --noEmit",
"test": "jest",
"test:ci": "npm run test -- --ci"
},
Expand All @@ -26,7 +27,6 @@
},
"devDependencies": {
"@slack-wrench/jest-mock-web-client": "^1.2.0",
"@types/jest": "^26.0.9",
"@types/supertest": "^2.0.10",
"@typescript-eslint/eslint-plugin": "^3.8.0",
"@typescript-eslint/parser": "^3.8.0",
Expand Down
10 changes: 9 additions & 1 deletion functions/src/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
import { describe, it, expect } from "@jest/globals";
import {
afterAll,
beforeEach,
afterEach,
describe,
it,
expect,
jest,
} from "@jest/globals";
import {
MockedWebClient,
MockWebClient,
Expand Down
2 changes: 1 addition & 1 deletion functions/src/model/__tests__/rotation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { describe, it, expect } from "@jest/globals";
import { describe, it, expect, jest } from "@jest/globals";
import { Rotation } from "../rotation";

describe("Rotation", () => {
Expand Down