GitHub Actions 上で型検査する

.github/workflows/ci.yml

@@ -15,6 +15,10 @@ jobs:
           node-version: "14.x"
       - run: npm ci
       - run: npm run lint:ci
+      - name: Type check
+        uses: gozala/[email protected]
+        with:
+          project: functions/tsconfig.json
       - name: Create serviceAccountKey.json for online testing
         run: echo "$SERVICE_ACCOUNT_KEY_JSON" > ../serviceAccountKey.json
         env:

functions/package.json

@@ -26,7 +26,6 @@
   },
   "devDependencies": {
     "@slack-wrench/jest-mock-web-client": "^1.2.0",
-    "@types/jest": "^26.0.9",
     "@types/supertest": "^2.0.10",
     "@typescript-eslint/eslint-plugin": "^3.8.0",
     "@typescript-eslint/parser": "^3.8.0",

functions/src/__tests__/index.test.ts

@@ -1,4 +1,12 @@
-import { describe, it, expect } from "@jest/globals";
+import {
+  afterAll,
+  beforeEach,
+  afterEach,
+  describe,
+  it,
+  expect,
+  jest,
+} from "@jest/globals";
 import {
   MockedWebClient,
   MockWebClient,

functions/src/model/__tests__/rotation.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect } from "@jest/globals";
+import { describe, it, expect, jest } from "@jest/globals";
 import { Rotation } from "../rotation";
 
 describe("Rotation", () => {

functions/src/slack.ts

@@ -43,7 +43,7 @@ export const createSlackApp = (
       });
       // 型定義上は optional だが、正常系では必ず存在するはず
       // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-      return json.members!.reduce<Record<string, string>>(
+      return json.members.reduce<Record<string, string>>(
         (acc, { id, profile }) => ({
           ...acc,
           // eslint-disable-next-line @typescript-eslint/no-non-null-assertion