Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#200 no exception error handling during absent state #203

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

git-cgallagher
Copy link
Contributor

Description

Adds conditional handling of result of Remove-DbaDatabase

Errors are not thrown for all failure scenarios

How Has This Been Tested?

Yes, locally

Types of changes

Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +6.18% 🎉

Comparison is base (104572c) 93.81% compared to head (1c7a336) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #203      +/-   ##
===========================================
+ Coverage   93.81%   100.00%   +6.18%     
===========================================
  Files          64        33      -31     
  Lines        2198       106    -2092     
===========================================
- Hits         2062       106    -1956     
+ Misses        136         0     -136     
Flag Coverage Δ
sanity 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-cgallagher
Copy link
Contributor Author

@lowlydba not sure what to make of that failure on codecov/patch

@lowlydba
Copy link
Owner

@lowlydba not sure what to make of that failure on codecov/patch

Its not a big deal, this one isn't worth setting up unit tests for due to the complexity.

@lowlydba lowlydba merged commit 247936b into lowlydba:main Aug 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] lowlydba.sqlserver.database drop database in availability group does not work
3 participants