Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: get/add/remove roles #162

Closed
wants to merge 55 commits into from

Conversation

jkrilov
Copy link
Contributor

@jkrilov jkrilov commented Dec 12, 2022

Description

New module to add/remove roles for a DB user.

How Has This Been Tested?

Integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue) - Fixes #
  • New feature (non-breaking change which adds functionality)

Checklist:

@jkrilov jkrilov changed the title Feat/add remove roles Feature: add remove roles Dec 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.21% ⚠️

Comparison is base (104572c) 93.81% compared to head (96a62a0) 89.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   93.81%   89.60%   -4.21%     
==========================================
  Files          64       54      -10     
  Lines        2198     1453     -745     
==========================================
- Hits         2062     1302     -760     
- Misses        136      151      +15     
Flag Coverage Δ
sanity 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/modules/role_member.py 100.00% <100.00%> (ø)
plugins/modules/role_member_info.py 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkrilov
Copy link
Contributor Author

jkrilov commented Dec 19, 2022

@lowlydba I'm seeing intermittent failures of sp_whoisactive.

Edit: Now I'm seeing the error every time on the Windows runners. I'll take a look this afternoon to see if I can determine the cause.

Copy link
Owner

@lowlydba lowlydba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no update on the Github 403 issues from my support ticket, so we can proceed with those still existing for now.

A few change requests, but otherwise looks good. Let me know if/when its ready for a final review.

plugins/modules/role_member_info.py Show resolved Hide resolved
plugins/modules/role_member.ps1 Outdated Show resolved Hide resolved
@lowlydba
Copy link
Owner

lowlydba commented Jan 6, 2023

@Joey40 If you rebase from main, I removed the EOL 2.11 version so there are fewer jobs now. Github support indicated its a rate limit issue mostly (per hour) so if this continues to be a problem giving a 60 minute cooloff should help the jobs to work.

@jkrilov
Copy link
Contributor Author

jkrilov commented Jan 6, 2023

Sounds good. Sorry I've been quiet for a couple weeks with the holidays and new year. I'll see if I can get this completed next week.

@Jvekka
Copy link

Jvekka commented Mar 10, 2023

This was actually something I was starting to build, but I noticed it already existed here.
Can I help with something to get going again?

@jkrilov
Copy link
Contributor Author

jkrilov commented Mar 10, 2023

This was actually something I was starting to build, but I noticed it already existed here.

Can I help with something to get going again?

I'll look this over today. I had some other work to do and honestly forgot to finish this.

If there's something you'd like that I haven't added feel free to let me know. I'd be happy to have the help.

@lowlydba
Copy link
Owner

lowlydba commented Oct 7, 2023

Going to close this for now as it is a bit stale, but feel free to re-open if you want to resume it.

@lowlydba lowlydba closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants