-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: get/add/remove roles #162
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 93.81% 89.60% -4.21%
==========================================
Files 64 54 -10
Lines 2198 1453 -745
==========================================
- Hits 2062 1302 -760
- Misses 136 151 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@lowlydba I'm seeing intermittent failures of sp_whoisactive. Edit: Now I'm seeing the error every time on the Windows runners. I'll take a look this afternoon to see if I can determine the cause. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still no update on the Github 403 issues from my support ticket, so we can proceed with those still existing for now.
A few change requests, but otherwise looks good. Let me know if/when its ready for a final review.
@Joey40 If you rebase from main, I removed the EOL 2.11 version so there are fewer jobs now. Github support indicated its a rate limit issue mostly (per hour) so if this continues to be a problem giving a 60 minute cooloff should help the jobs to work. |
Sounds good. Sorry I've been quiet for a couple weeks with the holidays and new year. I'll see if I can get this completed next week. |
This was actually something I was starting to build, but I noticed it already existed here. |
I'll look this over today. I had some other work to do and honestly forgot to finish this. If there's something you'd like that I haven't added feel free to let me know. I'd be happy to have the help. |
Co-authored-by: John McCall <[email protected]>
Co-authored-by: John McCall <[email protected]>
Update branch from main
Going to close this for now as it is a bit stale, but feel free to re-open if you want to resume it. |
Description
New module to add/remove roles for a DB user.
How Has This Been Tested?
Integration tests
Types of changes
Checklist:
version_added
property.