-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements: clean-up examples, throw_pretty in Python actuaction, and remove memory allocation in quasiStatic #980
Conversation
…seModel (quadruped)
It improves the readability of the code
…n model in Python
@wxmerkt -- do you know why the ROS-CIs are not passing? |
The momentum cost test failed. I restarted it in case it was flaky. However, it's likely that we are already using Pinocchio 2.6.3 on the ROS-CI which has the fixed centroidal momentum derivatives in case that has an impact here or requires adjustments to the unit test. |
I tested locally, the error appears with Pinocchio 2.3.6 (i.e., after the changes in stack-of-tasks/pinocchio#1474). It seems that we don't need anymore these lines: https://github.com/loco-3d/crocoddyl/blob/devel/include/crocoddyl/multibody/residuals/centroidal-momentum.hxx#L50-L52. At least, the test is passing if I remove them. @jcarpent -- I need your help here. Should I remove those lines? |
Yes, you have to. |
Yes, I put these lines as a local solution for the bug. Since we have now fixed it in pinocchio as well, we should also update the minimum version to 2.6.3 |
Also, it looks like LAAS-CNRS is missing from the copyright in all residual models. Since the residual-models were refactored from the original cost-models, the copyright should remain. |
…inal code developed at LAAS
…xed in Pinocchio 2.6.3
Done! The code is ready to be merged; however, gitlab-ci is failing since we need to deploy 2.6.3 in robotpkg. @nim65s -- do you know when it is expected the new release. |
I will merge this PR as ROS-CI is checking all the unittests (and I don't want to wait for |
We could have used a version check instead of requiring the latest version. |
I indeed though about this possibility, but it seems more convenient to constrain everyone moving to another version as this is a bug. |
@cmastalli Accepting PRs when CI is failing is never a good idea. It might not be the cleanest way forward, but it is better to leave a PR open than to accept it without the CI. |
There is redundancy, the ROS-CI is testing the same bits but with Pinocchio 2.6.3. |
The changes on the examples are targeted to extend them along a set of cases that used inverse-dynamics (instead of the current forward dynamics).
Note that the inverse-dynamics based optimal control is still an ongoing work which will be released in Crocoddyl v2.