[RTG] Add set type and operations #7848
Open
+117
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
approved these changes
Nov 20, 2024
| "set", "output", | ||
| "llvm::cast<rtg::SetType>($_self).getElementType()"> | ||
| ]> { | ||
| let summary = "selects an element uniformly at random from a set"; |
There was a problem hiding this comment.
What does this return if the set is empty?
There was a problem hiding this comment.
This is currently undefined behavior. My plan is to add another operation to query the number of elements in the set. scf.if could then be used to skip random selections from empty sets. Alternatively, we could pass a default value to be chosen if the set is empty. Feel free to share your thoughts/opinion on how this should ideally be handled.
maerhart
force-pushed
the
maerhart-rtgtest-dialect
branch
from
ef89957
to
95eebf3
Compare
maerhart
force-pushed
the
maerhart-rtg-sets
branch
from
260d648
to
b45b8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.