Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xilem_web: Fix message type of AnyDomView and add .boxed() combinator #460

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

Philipp-M
Copy link
Contributor

@Philipp-M Philipp-M commented Jul 28, 2024

Fixes the issue described in #459.
I guess I missed this when adding #408, the doc-test should ensure that Box<AnyDomView> is now really a DomView.

@Philipp-M Philipp-M linked an issue Jul 28, 2024 that may be closed by this pull request
@Philipp-M Philipp-M changed the title xilem_web: Fix #459, and add .boxed() combinator xilem_web: Fix the issue described in #459, and add .boxed() combinator Jul 28, 2024
@DJMcNab
Copy link
Member

DJMcNab commented Jul 29, 2024

I'm not sure this is a great PR title. The reference to #459 should be moved into the description.

I.e. I would use ta title like:
"xilem_web: Fix message type of AnyDomView and add .boxed() combinator"

xilem_web/src/lib.rs Outdated Show resolved Hide resolved
@Philipp-M Philipp-M changed the title xilem_web: Fix the issue described in #459, and add .boxed() combinator xilem_web: Fix message type of AnyDomView and add .boxed() combinator Jul 29, 2024
@Philipp-M Philipp-M enabled auto-merge July 29, 2024 09:17
@Philipp-M Philipp-M added this pull request to the merge queue Jul 29, 2024
Merged via the queue into linebender:main with commit 1b1a1d3 Jul 29, 2024
16 checks passed
@Philipp-M Philipp-M deleted the xilem_web-fix-broken-any-view branch July 29, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants