xilem_web: Possible bug when using .boxed and changing type of HTML node

[casey]

I think I found an issue when using .boxed combinator from #460 and using it to dynamically change the type of HTML element.

I created a minimal reproduction here, which looks like this:

use xilem_web::{document_body, elements::html, interfaces::Element, App, DomView};

fn update(state: &mut bool) -> impl DomView<bool> {
    html::div((
        html::button("click me!").on_click(|state: &mut bool, _| *state = !*state),
        html::br(()),
        if *state {
            html::div("div!").boxed()
        } else {
            html::span("span!").boxed()
        },
    ))
}

fn main() {
    App::new(document_body(), false, update).run();
}

The boxed element keeps it's initial type and text, even when the button is clicked. If the state is false initially, it stays a <span>, and if true a <div>.

[Philipp-M]

Thanks for the repro, that made fixing this easy, internally the element was changed, but the actual DOM node in the tree wasn't.

[casey]

Nice! Thanks for the fix!