Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .NET version of tcp/noise/yamux #298
base: master
Are you sure you want to change the base?
Add .NET version of tcp/noise/yamux #298
Changes from 11 commits
93c53c4
d7ec962
57a5aac
bf6f881
274d899
6432044
bd8638e
db8684c
b5b3c8f
2602a87
46a190f
9f7fd11
45dc066
fd26bae
7e05b0b
0303809
3a21628
67674e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all other implementations, we keep the actual test within the respective libp2p repository so it can be atomically updated with the library code.
Unless there is a strong reason to not do that for
.net
, I'd suggest to do the same here.