Add .NET version of tcp/noise/yamux #298
Conversation
|
Let's add quic also, converting to draft |
|
Approved and ran CI.
I am happy to merge here without QUIC already. Your call. |
|
@flcl42 seems like dotnet is failing with all other implementations. Mind taking a look? |
The current implementation:
If it's better to have it 100% passing, let me disable quic for now. |
There was a problem hiding this comment.
For all other implementations, we keep the actual test within the respective libp2p repository so it can be atomically updated with the library code.
Unless there is a strong reason to not do that for .net, I'd suggest to do the same here.
There was a problem hiding this comment.
I am assuming this needs to be reverted?
| @@ -9,7 +9,7 @@ import { stringify } from 'yaml'; | |||
| import { dialerStdout, dialerTimings } from './compose-stdout-helper'; | |||
|
|
|||
| const exec = util.promisify(execStd); | |||
| const timeoutSecs = 3 * 60 | |||
| const timeoutSecs = 42 | |||
There was a problem hiding this comment.
Is this intentional?
| @@ -50,7 +50,9 @@ export async function run(namespace: string, compose: ComposeSpecification, opts | |||
| const controller = new AbortController(); | |||
| const timeoutId = setTimeout(() => controller.abort(), 1000 * timeoutSecs) | |||
| const { signal } = controller; | |||
| const { stdout, stderr } = await exec(`docker compose -f ${path.join(dir, "compose.yaml")} up ${upFlags.join(" ")}`, { signal }) | |||
| const dcPath = `docker compose -f ${path.join(dir, "compose.yaml")} up ${upFlags.join(" ")}` | |||
| console.warn(dcPath) | |||
There was a problem hiding this comment.
I'd prefer making this a more descriptive log line if we intend to keep it.
|
@thomaseizinger Thanks for the remarks! Right now we are refactoring/fixing the library to fit the tests. I'll also address the suggestions in new update. |
Adds .NET implementation of tcp/noise/yamux stack of libp2p to the interoperability testing suite