Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Note external user ids must be a non-empty string array #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Note external user ids must be a non-empty string array #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ public function routeNotificationForOneSignal()

If you want to send the notification based on an external user id you set using the `setExternalUserId` feature. This makes it really easy to target users based on their Laravel User Ids.

**Note:** `include_external_user_ids` must be an array of non empty strings

```php
public function routeNotificationForOneSignal()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example should be updated too, something like:

public function routeNotificationForOneSignal()
{
  return ['include_external_user_ids' => [strval($this->id)]];
}

{
Expand Down