Add Note external user ids must be a non-empty string array #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that include_external_user_ids must be a non-empty string array.
cfiorillo
suggested changes
May 7, 2021
| @@ -124,6 +124,8 @@ public function routeNotificationForOneSignal() | |||
|
|
|||
| If you want to send the notification based on an external user id you set using the `setExternalUserId` feature. This makes it really easy to target users based on their Laravel User Ids. | |||
|
|
|||
| **Note:** `include_external_user_ids` must be an array of non empty strings | |||
|
|
|||
| ```php | |||
| public function routeNotificationForOneSignal() | |||
There was a problem hiding this comment.
The example should be updated too, something like:
public function routeNotificationForOneSignal()
{
return ['include_external_user_ids' => [strval($this->id)]];
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that include_external_user_ids must be a non-empty string array.