Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve node module macos-alias installation on non-macOS platforms #2942

Merged

Conversation

studioego
Copy link
Contributor

fix: Resolve node module macos-alias installation on non-macOS platforms

Reference:

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link

graphite-app bot commented Dec 11, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added area:lib Library and SDK related issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). type:fix Fix features that are not working size:XS ~10 LoC labels Dec 11, 2024
Copy link

graphite-app bot commented Dec 11, 2024

Merge activity

  • Dec 11, 4:11 PM UTC: @studioego we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

  • Dec 12, 1:12 AM EST: The merge label 'flow:hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 15, 9:29 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 15, 9:31 PM EST: A user merged this pull request with the Graphite merge queue.

@github-actions github-actions bot added size:XL 500~ LoC and removed size:XS ~10 LoC labels Dec 11, 2024
@yomybaby yomybaby force-pushed the fix/bai-webui-mod-package-json-optiondependencies branch from 0c11c79 to 66820e9 Compare December 16, 2024 02:26
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XL 500~ LoC labels Dec 16, 2024
Copy link
Member

yomybaby commented Dec 16, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were too many unnecessary changes in pnpm-lock.yaml. I committed a new pnpm-lock.yaml generated by running pnpm install with the updated package.json from the main branch.

Now, LGTM. Thank you for your contribution.

…rms (#2942)

fix: Resolve node module macos-alias installation on non-macOS platforms
- Add `optionalDependencies` for node module `macos-alias` in package.json
- Prevent npm build failures on Linux platform & non-macOS platforms
closes #2941

Reference:
* npm Doc: package.json's optionalDependencies section
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#optionaldependencies
* what's the difference of optionalDependencies and peerDependenciesMeta's optional? https://stackoverflow.com/questions/74916906/whats-the-difference-of-optionaldependencies-and-peerdependenciesmetas-optiona

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [x] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@studioego studioego force-pushed the fix/bai-webui-mod-package-json-optiondependencies branch from 66820e9 to 91a635f Compare December 16, 2024 02:30
@graphite-app graphite-app bot merged commit 91a635f into main Dec 16, 2024
5 checks passed
@graphite-app graphite-app bot deleted the fix/bai-webui-mod-package-json-optiondependencies branch December 16, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:lib Library and SDK related issue. effort:easy Need to understand only a specific region of codes (good first issue, easy). flow:hotfix platform:general size:M 30~100 LoC type:fix Fix features that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm build fails on Linux: macos-alias module incompatible with non-macOS platforms
2 participants