-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Resolve node module macos-alias installation on non-macOS platforms #2942
fix: Resolve node module macos-alias installation on non-macOS platforms #2942
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Merge activity
You must have a Graphite account in order to use the merge queue. Create an account and try again using this link
|
0c11c79
to
66820e9
Compare
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were too many unnecessary changes in pnpm-lock.yaml
. I committed a new pnpm-lock.yaml
generated by running pnpm install
with the updated package.json
from the main branch.
Now, LGTM. Thank you for your contribution.
…rms (#2942) fix: Resolve node module macos-alias installation on non-macOS platforms - Add `optionalDependencies` for node module `macos-alias` in package.json - Prevent npm build failures on Linux platform & non-macOS platforms closes #2941 Reference: * npm Doc: package.json's optionalDependencies section https://docs.npmjs.com/cli/v10/configuring-npm/package-json#optionaldependencies * what's the difference of optionalDependencies and peerDependenciesMeta's optional? https://stackoverflow.com/questions/74916906/whats-the-difference-of-optionaldependencies-and-peerdependenciesmetas-optiona <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
66820e9
to
91a635f
Compare
fix: Resolve node module macos-alias installation on non-macOS platforms
optionalDependencies
for node modulemacos-alias
in package.jsoncloses npm build fails on Linux: macos-alias module incompatible with non-macOS platforms #2941
Reference:
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#optionaldependencies
Checklist: (if applicable)