Skip to content

Commit

Permalink
fix: Resolve node module macos-alias installation on non-macOS platfo…
Browse files Browse the repository at this point in the history
…rms (#2942)

fix: Resolve node module macos-alias installation on non-macOS platforms
- Add `optionalDependencies` for node module `macos-alias` in package.json
- Prevent npm build failures on Linux platform & non-macOS platforms
closes #2941

Reference:
* npm Doc: package.json's optionalDependencies section
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#optionaldependencies
* what's the difference of optionalDependencies and peerDependenciesMeta's optional? https://stackoverflow.com/questions/74916906/whats-the-difference-of-optionaldependencies-and-peerdependenciesmetas-optiona

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [x] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
  • Loading branch information
studioego committed Dec 16, 2024
1 parent cc2f9a1 commit 91a635f
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 44 deletions.
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,9 @@
"workbox-sw": "^7.1.0",
"ws": "^8.18.0"
},
"optionalDependencies": {
"macos-alias": "^0.2.11"
},
"overrides": {
"eslint": "^8.57.0"
},
Expand Down
Loading

0 comments on commit 91a635f

Please sign in to comment.