Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use folder explorer and create a new folder in session launcher #90

Merged
merged 2 commits into from
Nov 22, 2024
Merged

docs: use folder explorer and create a new folder in session launcher #90

merged 2 commits into from
Nov 22, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Oct 24, 2024 •
edited
Loading

@ironAiken2 Graphite App
Copy link
Contributor Author

ironAiken2 commented Oct 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 mentioned this pull request Oct 23, 2024
Open
@ironAiken2 ironAiken2 self-assigned this Oct 24, 2024
@ironAiken2 ironAiken2 marked this pull request as ready for review October 24, 2024 02:02
@ironAiken2 ironAiken2 force-pushed the docs/mounting-folder-to-a-compute-session branch 2 times, most recently from 4cd0771 to 3e4c490 Compare October 24, 2024 05:17
YEONFEEL96
YEONFEEL96 requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@YEONFEEL96 YEONFEEL96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuild 'mount_vfolder' document to match latest UI and writing guideline.

docs/locale/ko/LC_MESSAGES/mount_vfolder/mount_vfolder.po Outdated Show resolved Hide resolved
YEONFEEL96
YEONFEEL96 requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@YEONFEEL96 YEONFEEL96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebuild 'mount_vfolder' document to match latest UI and writing guideline.

@ironAiken2 ironAiken2 force-pushed the docs/mounting-folder-to-a-compute-session branch 2 times, most recently from 0cf1369 to 171b0fc Compare October 25, 2024 04:15
@ironAiken2 Graphite App
Copy link
Contributor Author

Rebuild 'mount_vfolder' document to match latest UI and writing guideline.

I've incorporated all the changes you've written. @YEONFEEL96

@ironAiken2 ironAiken2 requested a review from YEONFEEL96 October 25, 2024 04:20
@ironAiken2 ironAiken2 force-pushed the docs/mounting-folder-to-a-compute-session branch from 171b0fc to 63cd783 Compare October 25, 2024 04:48
YEONFEEL96
YEONFEEL96 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@YEONFEEL96 YEONFEEL96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Looks Good To Me.

This was referenced Nov 13, 2024
Merged
Merged
Merged
Open
Open
Open
Open
@ironAiken2 ironAiken2 force-pushed the docs/mounting-folder-to-a-compute-session branch from 63cd783 to 2781f4b Compare November 22, 2024 03:56
@ironAiken2 Graphite App
Copy link
Contributor Author

ironAiken2 commented Nov 22, 2024 •
edited
Loading

Merge activity

  • Nov 22, 12:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 22, 12:37 AM EST: A user merged this pull request with Graphite.

@ironAiken2 ironAiken2 merged commit 17bd33c into main Nov 22, 2024
2 checks passed
@ironAiken2 ironAiken2 deleted the docs/mounting-folder-to-a-compute-session branch November 22, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YEONFEEL96 YEONFEEL96 YEONFEEL96 approved these changes

@lizable lizable Awaiting requested review from lizable

Assignees

@ironAiken2 ironAiken2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ironAiken2 @YEONFEEL96