Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add session history feature, folder explorer and folder create modal descriptions #86

Merged
merged 4 commits into from
Nov 22, 2024
Merged

docs: add session history feature, folder explorer and folder create modal descriptions #86

merged 4 commits into from
Nov 22, 2024

Conversation

ironAiken2
Copy link
Contributor

@ironAiken2 ironAiken2 commented Oct 23, 2024 •
edited
Loading

This PR is about updating sessions section for 24.09

Changes:

  • Starting with Backend.AI version 24.09, NEO session launcher is used as the default session launcher.
  • Added session owner setting feature.
  • Added session histyro search function.
  • Added folder explorer and vfoler creation function in session launcher page.

Related PRs:

@ironAiken2 Graphite App
Copy link
Contributor Author

ironAiken2 commented Oct 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ironAiken2 ironAiken2 self-assigned this Oct 23, 2024
@ironAiken2 ironAiken2 marked this pull request as ready for review October 23, 2024 06:48
@ironAiken2 ironAiken2 mentioned this pull request Oct 23, 2024
Open
@ironAiken2 ironAiken2 changed the title docs: update sessions section docs: add session history feature, folder explorer and folder create modal descriptions Oct 23, 2024
@ironAiken2 ironAiken2 force-pushed the docs/sessions-section branch from e9384e5 to 5f37420 Compare October 24, 2024 05:18
@YEONFEEL96
Copy link
Contributor

  • Modified english expression on /sessions-section/sessions_all.rst
  • Matched menu name with actual WebUI interface
    36c6e98

YEONFEEL96
YEONFEEL96 previously approved these changes Oct 25, 2024
View reviewed changes
@YEONFEEL96 YEONFEEL96 dismissed their stale review October 25, 2024 06:37

Need to update ko-KR of this document.

@ironAiken2 ironAiken2 force-pushed the docs/sessions-section branch from 36c6e98 to 2b0e0cf Compare October 25, 2024 06:42
YEONFEEL96
YEONFEEL96 requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@YEONFEEL96 YEONFEEL96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about version. Is it fine to leave this as 20.03? @ironAiken2

@ironAiken2 ironAiken2 requested a review from YEONFEEL96 October 28, 2024 01:47
YEONFEEL96
YEONFEEL96 requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@YEONFEEL96 YEONFEEL96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed two small typos in english document.

docs/sessions_all/sessions_all.rst Outdated Show resolved Hide resolved
docs/sessions_all/sessions_all.rst Outdated Show resolved Hide resolved
@ironAiken2 ironAiken2 force-pushed the docs/sessions-section branch from 132c8e0 to cfe77a3 Compare November 13, 2024 08:09
@ironAiken2 ironAiken2 changed the base branch from main to docs/mounting-folder-to-a-compute-session November 13, 2024 08:09
This was referenced Nov 13, 2024
Merged
Merged
Merged
Open
Open
Open
Open
YEONFEEL96
YEONFEEL96 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@YEONFEEL96 YEONFEEL96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ironAiken2 ironAiken2 force-pushed the docs/mounting-folder-to-a-compute-session branch from 63cd783 to 2781f4b Compare November 22, 2024 03:56
@ironAiken2 ironAiken2 force-pushed the docs/sessions-section branch 2 times, most recently from 36993d9 to d4f142e Compare November 22, 2024 05:00
@ironAiken2 Graphite App
Copy link
Contributor Author

ironAiken2 commented Nov 22, 2024 •
edited
Loading

Merge activity

  • Nov 22, 12:36 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 22, 12:39 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 22, 12:40 AM EST: A user merged this pull request with Graphite.

@ironAiken2 ironAiken2 changed the base branch from docs/mounting-folder-to-a-compute-session to graphite-base/86 November 22, 2024 05:37
@ironAiken2 ironAiken2 changed the base branch from graphite-base/86 to main November 22, 2024 05:37
@ironAiken2 ironAiken2 force-pushed the docs/sessions-section branch from d4f142e to dc3ce71 Compare November 22, 2024 05:38
@ironAiken2 ironAiken2 merged commit 80af5a0 into main Nov 22, 2024
2 checks passed
@ironAiken2 ironAiken2 deleted the docs/sessions-section branch November 22, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YEONFEEL96 YEONFEEL96 YEONFEEL96 approved these changes

@yomybaby yomybaby Awaiting requested review from yomybaby

@lizable lizable Awaiting requested review from lizable

Assignees

@ironAiken2 ironAiken2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ironAiken2 @YEONFEEL96