project-infra: add make targets lint and coverage #3825

dhiller · 2024-12-12T18:54:46Z

What this PR does / why we need it:

Adds the coverage and lint make targets and the initial .golangci-lint configuration.

Also it adds //nolint directive to some of the files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3822

Special notes for your reviewer:

kubevirt-bot · 2024-12-12T18:54:49Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Adds the lint make target and the initial .golangci-lint configuration. Also it adds //nolint directive to some of the files Signed-off-by: Daniel Hiller <[email protected]>

Adds a make target that writes a coverage report to ARTIFACTS output directory sub directory. Signed-off-by: Daniel Hiller <[email protected]>

Signed-off-by: Daniel Hiller <[email protected]>

dhiller · 2024-12-16T12:37:56Z

/rehearse ?

kubevirt-bot · 2024-12-16T12:38:37Z

Rehearsal is available for the following jobs in this PR:

pull-project-infra-lint
pull-project-infra-coverage

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

Signed-off-by: Daniel Hiller <[email protected]>

dhiller · 2024-12-16T12:43:52Z

/rehearse

kubevirt-bot · 2024-12-16T12:44:02Z

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-lint
rehearsal-pull-project-infra-coverage

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

Signed-off-by: Daniel Hiller <[email protected]>

dhiller · 2024-12-17T08:59:56Z

/rehearse pull-project-infra-coverage

kubevirt-bot · 2024-12-17T09:00:10Z

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-coverage

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller · 2024-12-17T09:37:02Z

/rehearse pull-project-infra-lint

kubevirt-bot · 2024-12-17T09:37:43Z

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-lint

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller · 2024-12-17T09:41:31Z

Coverage report here: https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3825/rehearsal-pull-project-infra-coverage/1868944261240590336/artifacts/coverage.html

dhiller · 2024-12-17T10:00:17Z

/rehearse pull-project-infra-lint

kubevirt-bot · 2024-12-17T10:00:33Z

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-lint

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller · 2024-12-17T11:45:50Z

@brianmcarey mind taking a look? Rehearsal jobs work as expected. (Have decided to add the status in another PR.)

brianmcarey

thanks @dhiller for this - added a couple of comments inline.

Makefile

.golangci.yaml

brianmcarey · 2024-12-17T14:06:06Z

releng/release-tool/release-tool.go

@@ -772,7 +772,7 @@ func (r *releaseData) getReleases() ([]*github.RepositoryRelease, error) {
 	return r.allReleases, nil
 }

-func (r *releaseData) autoDetectData(autoReleaseCadance string, autoPromoteAfterDays int) error {
+func (r *releaseData) autoDetectData(autoReleaseCadance string, autoPromoteAfterDays int) error { //nolint:gocyclo


Are these nolints here just to get something running initially?

yes, also the git grep is to remind us to remove them

brianmcarey · 2024-12-17T14:07:53Z

github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

+      containers:
+      - args:
+        - |
+          GOBIN=/usr/local/bin/ go install github.com/onsi/ginkgo/v2/[email protected]


Having a specific image for this would remove the need for this.

true - but since we only need this in two cases currently I am not sure whether it's worth it. Also I don't want to put this into the golang image, doesn't seem like a good fit. Maybe some project-infra-test image? WDYT?
(I am not really sure whether we would want to tackle that in this PR, maybe create an issue as tracker?)

Signed-off-by: Daniel Hiller <[email protected]>

dhiller · 2024-12-17T15:32:52Z

@brianmcarey addressed comments, PTAL thanks!

brianmcarey

/approve

thanks @dhiller !

kubevirt-bot · 2024-12-18T14:51:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [brianmcarey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dhiller · 2024-12-19T11:25:38Z

/override pull-project-infra-prow-deploy-test

kubevirt-bot · 2024-12-19T11:25:42Z

@dhiller: Overrode contexts on behalf of dhiller: pull-project-infra-prow-deploy-test

In response to this:

/override pull-project-infra-prow-deploy-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot · 2024-12-19T11:26:10Z

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

key project-infra-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml

In response to this:

What this PR does / why we need it:

Adds the coverage and lint make targets and the initial .golangci-lint configuration.

Also it adds //nolint directive to some of the files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3822

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2024

kubevirt-bot requested review from brianmcarey and enp0s3 December 12, 2024 18:54

kubevirt-bot added the size/L label Dec 12, 2024

dhiller force-pushed the add-lint branch from 72333f1 to 911aa34 Compare December 12, 2024 19:03

kubevirt-bot added size/M and removed size/L labels Dec 12, 2024

dhiller added 3 commits December 16, 2024 13:14

lint: add make target lint

7b47022

Adds the lint make target and the initial .golangci-lint configuration. Also it adds //nolint directive to some of the files Signed-off-by: Daniel Hiller <[email protected]>

coverage: add make target

5190e56

Adds a make target that writes a coverage report to ARTIFACTS output directory sub directory. Signed-off-by: Daniel Hiller <[email protected]>

project-infra: add presubmits for lint and coverage

1681f2b

Signed-off-by: Daniel Hiller <[email protected]>

dhiller force-pushed the add-lint branch from 911aa34 to 1681f2b Compare December 16, 2024 12:36

kubevirt-bot added size/L and removed size/M labels Dec 16, 2024

makefile: replace indentation with tabs

aed9d37

Signed-off-by: Daniel Hiller <[email protected]>

dhiller marked this pull request as ready for review December 16, 2024 12:47

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024

kubevirt-bot requested a review from xpivarc December 16, 2024 12:47

dhiller changed the title ~~lint: add make target lint~~ project-infra: add make targets lint and coverage Dec 16, 2024

dhiller marked this pull request as draft December 16, 2024 16:49

kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024

add ginkgo

22defd1

Signed-off-by: Daniel Hiller <[email protected]>

dhiller marked this pull request as ready for review December 17, 2024 11:44

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024

brianmcarey reviewed Dec 17, 2024

View reviewed changes

dhiller mentioned this pull request Dec 17, 2024

lint: enable all standard linters on project-infra #3837

Open

8 tasks

coverage: inline make-artifacts target

4ecbf47

Signed-off-by: Daniel Hiller <[email protected]>

dhiller requested a review from brianmcarey December 17, 2024 15:32

brianmcarey approved these changes Dec 18, 2024

View reviewed changes

kubevirt-bot assigned brianmcarey Dec 18, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024

kubevirt-bot merged commit 83f8029 into kubevirt:main Dec 19, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

project-infra: add make targets lint and coverage #3825

project-infra: add make targets lint and coverage #3825

dhiller commented Dec 12, 2024 •

edited

Loading

kubevirt-bot commented Dec 12, 2024

dhiller commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

dhiller commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

dhiller commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

dhiller commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

dhiller commented Dec 17, 2024

dhiller commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

dhiller commented Dec 17, 2024

brianmcarey left a comment

brianmcarey Dec 17, 2024

dhiller Dec 17, 2024

brianmcarey Dec 17, 2024

dhiller Dec 17, 2024

dhiller commented Dec 17, 2024

brianmcarey left a comment

kubevirt-bot commented Dec 18, 2024

dhiller commented Dec 19, 2024

kubevirt-bot commented Dec 19, 2024

kubevirt-bot commented Dec 19, 2024

project-infra: add make targets lint and coverage #3825

project-infra: add make targets lint and coverage #3825

Conversation

dhiller commented Dec 12, 2024 • edited Loading

kubevirt-bot commented Dec 12, 2024

dhiller commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

dhiller commented Dec 16, 2024

kubevirt-bot commented Dec 16, 2024

dhiller commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

dhiller commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

dhiller commented Dec 17, 2024

dhiller commented Dec 17, 2024

kubevirt-bot commented Dec 17, 2024

dhiller commented Dec 17, 2024

brianmcarey left a comment

Choose a reason for hiding this comment

brianmcarey Dec 17, 2024

Choose a reason for hiding this comment

dhiller Dec 17, 2024

Choose a reason for hiding this comment

brianmcarey Dec 17, 2024

Choose a reason for hiding this comment

dhiller Dec 17, 2024

Choose a reason for hiding this comment

dhiller commented Dec 17, 2024

brianmcarey left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Dec 18, 2024

dhiller commented Dec 19, 2024

kubevirt-bot commented Dec 19, 2024

kubevirt-bot commented Dec 19, 2024

dhiller commented Dec 12, 2024 •

edited

Loading