Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: enable all standard linters on project-infra #3837

Open
8 tasks
dhiller opened this issue Dec 17, 2024 · 2 comments
Open
8 tasks

lint: enable all standard linters on project-infra #3837

dhiller opened this issue Dec 17, 2024 · 2 comments
Labels
help wanted Identifies an issue that has been specifically created or selected for new contributors. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/enhancement wg/code-quality Denotes an issue or PR that relates to the code-quality working group.

Comments

@dhiller
Copy link
Contributor

dhiller commented Dec 17, 2024

Is your feature request related to a problem? Please describe:
As a follow up to #3822 we want to enable the golangci-lint rules that have been disabled in the PR #3825 that integrated the linter but disabled the default linters: https://github.com/dhiller/project-infra/blob/22defd18943880ba3aa05fa11bfeb7203c545774/.golangci.yaml#L6-L14

Describe the solution you'd like:

Goals/Linters to enable:

  • staticcheck
  • unused
  • ineffassign
  • govet
  • gosimple
  • errcheck
  • gocyclo with setting: min-complexity: 10 (default is 30)
  • remove all //nolint directives

Describe alternatives you've considered:

Additional context:

@dhiller
Copy link
Contributor Author

dhiller commented Dec 17, 2024

/kind cleanup
/wg code-quality
/help

@kubevirt-bot
Copy link
Contributor

@dhiller:
This request has been marked as needing help from a contributor.

Guidelines

  • No Barrier to Entry
  • Clear Task
  • Solution Explained
  • Provides Context
  • Identifies Relevant Code
  • Gives Examples
  • Ready to Test
  • Goldilocks priority
  • Up-To-Date

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind cleanup
/wg code-quality
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Identifies an issue that has been specifically created or selected for new contributors. wg/code-quality Denotes an issue or PR that relates to the code-quality working group. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Identifies an issue that has been specifically created or selected for new contributors. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/enhancement wg/code-quality Denotes an issue or PR that relates to the code-quality working group.
Projects
None yet
Development

No branches or pull requests

2 participants