Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPO: add apidiff optional job #32644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −0
Open

CAPO: add apidiff optional job #32644

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ...rnetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,28 @@ presubmits:
annotations:
testgrid-dashboards: sig-cluster-lifecycle-cluster-api-provider-openstack
testgrid-tab-name: pr-e2e-full-test
- name: pull-cluster-api-provider-openstack-apidiff
cluster: eks-prow-build-cluster
decorate: true
path_alias: sigs.k8s.io/cluster-api-provider-openstack
optional: true
branches:
# The script this job runs is not in all branches.
- ^main$
run_if_changed: '^((api|config|controllers|hack|scripts|test|version)/|main\.go|go\.mod|go\.sum|Dockerfile|Makefile)'
spec:
containers:
- command:
- runner.sh
- ./scripts/ci-apidiff.sh
image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240515-17c6d50e24-1.30
resources:
requests:
cpu: 6000m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this is pretty high. We have 4 CPU for the unit tests. I think it is fine to start like this though. We can adjust if it turns out to be more than needed.

memory: 2Gi
limits:
cpu: 6000m
memory: 2Gi
annotations:
testgrid-dashboards: sig-cluster-lifecycle-cluster-api-provider-openstack
testgrid-tab-name: pr-apidiff