Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPO: add apidiff optional job #32644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CAPO: add apidiff optional job #32644

wants to merge 1 commit into from
+25 −0

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented May 22, 2024 •
edited
Loading

Add a new job to run apidiff on CAPO main PRs.

TODO:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs labels May 22, 2024
@EmilienM
Copy link
Contributor Author

We need kubernetes-sigs/cluster-api-provider-openstack#2096 first.

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 22, 2024
@EmilienM
Copy link
Contributor Author

/cc mdbooth lentzi90

@k8s-ci-robot k8s-ci-robot requested a review from mdbooth May 22, 2024 16:08
@EmilienM
Copy link
Contributor Author

Related to kubernetes-sigs/cluster-api-provider-openstack#1860

@EmilienM EmilienM marked this pull request as draft May 22, 2024 16:21
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@EmilienM EmilienM marked this pull request as ready for review May 22, 2024 16:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@EmilienM
Copy link
Contributor Author

/hold for dependency to land once we figure out how we want to run it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2024
@mdbooth
Copy link
Contributor

mdbooth commented May 23, 2024

We need kubernetes-sigs/cluster-api-provider-openstack#2096 first.

Can you put this dependency in the description as a TODO item?

@EmilienM EmilienM changed the title CAPO: add apidiff job CAPO: add apidiff optional job May 31, 2024
@mdbooth mdbooth mentioned this pull request May 31, 2024
Merged
lentzi90
lentzi90 reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

...ubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml
image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20240515-17c6d50e24-1.30
resources:
requests:
cpu: 6000m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that this is pretty high. We have 4 CPU for the unit tests. I think it is fine to start like this though. We can adjust if it turns out to be more than needed.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2024
@EmilienM
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@lentzi90 lentzi90

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EmilienM @k8s-ci-robot @mdbooth @lentzi90