Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert nest-asyncio #44

Merged
merged 1 commit into from
May 1, 2023
Merged

Revert nest-asyncio #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions kr8s/_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
import inspect
from typing import Any, AsyncGenerator, Callable, Generator, Tuple

import nest_asyncio

nest_asyncio.apply()


def _get_event_loop() -> asyncio.AbstractEventLoop:
try:
Expand Down
1 change: 1 addition & 0 deletions kr8s/tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def test_version_sync():
assert "major" in version


@pytest.mark.xfail(reason="Cannot run nested event loops", raises=RuntimeError)
async def test_version_sync_in_async():
kubernetes = kr8s.api()
version = kubernetes.version()
Expand Down
14 changes: 1 addition & 13 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ python = "^3.8"
aiohttp = "^3.8.4"
pyyaml = "^6.0"
asyncio-atexit = "^1.0.1"
nest-asyncio = "^1.5.6"


[tool.poetry.group.test.dependencies]
Expand Down