Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert nest-asyncio #44

Merged
merged 1 commit into from
May 1, 2023

Conversation

jacobtomlinson
Copy link
Member

Revert #42

Adding nest-asyncio has caused #43 which is more painful than not having sync in asyncio. Reverting for now and reopening #41 to track adding this ability back in.

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #44 (56036ab) into main (075fdc5) will increase coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   96.36%   96.68%   +0.31%     
==========================================
  Files          21       21              
  Lines        1568     1567       -1     
==========================================
+ Hits         1511     1515       +4     
+ Misses         57       52       -5     
Impacted Files Coverage Δ
kr8s/_asyncio.py 91.07% <ø> (+6.58%) ⬆️
kr8s/tests/test_api.py 99.00% <100.00%> (-1.00%) ⬇️

... and 2 files with indirect coverage changes

@jacobtomlinson jacobtomlinson merged commit c7a0146 into kr8s-org:main May 1, 2023
@jacobtomlinson jacobtomlinson deleted the remove-nest-asyncio branch May 1, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant