-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BattleOrders tardy check and quit/continue vars #2013
base: master
Are you sure you want to change the base?
Conversation
This removes the unnecessary delay when someone rejoins a game or joins late and the time for battle orders has passed. The bot will now check for other player locations and just continue on instead of waiting the BattleOrder timeout. Instead of quitting if the timeout is reached, now the character can optionally just continue on with the run. These two changes combined make for smoother battle order control.
So, if the leader is the bo-er, it simply doesnt bo, and moves on the the next script. As the leader, comes in game as first, and therefor seems to be empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an neat addition, specially removing the force quiting on failure. As, sometimes you specifically want this, and sometimes specifically do not want this.
Got some minor points of improvement, attach to much judgement to my review, as its a matter of interpretation / different point of view
Hmm. I've found that even if the leader is the BOer, the I have three bots running, one is the leader, a second one is the BOer, and a third just tags along and helps with assistant scripts. The problems I've run into that caused this PR were if one of the bots was doing automule, the others would quit the game, or wait at the BO if it happened to be the BOer that was muling or FTJ. I'll take another pass at this though, to add some more smoothing for other situations that aren't as specific as mine. Thanks for your feedback! |
I've made this more robust and clean. It should be ready for final review. Thanks! |
fd2ac27
to
9ae6bba
Compare
This removes the unnecessary delay when someone rejoins a game or joins
late and the time for battle orders has passed. The bot will now check
for other player locations and just continue on instead of waiting the
BattleOrder timeout. Instead of quitting if the timeout is reached,
now the character can optionally just continue on with the run. These
two changes combined make for smoother battle order control.