language server function generation #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWhiting
force-pushed
the
eq_gen_language_server
branch
from
06db5ae to
0259b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates functions for
(==)cmpshowandorder2from datatype definition. However, unlike #335 this does it from the language server code action rather than automatically. This allows for more flexibility in working with effects for now, and also allows for greater customization ofshowafter generation, while handling most of the boilerplate. We could also add a generic empty template for "adding a method" which would just create a function of one parameter of that type that immediately matches on the datatype, using the correct names of the fields. This would save a lot of typing and make the language server even more useful, while keeping consistent methods using the right / full names of fields.