do rbac in xdp prog #712
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| /* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ | ||
| /* Copyright Authors of Kmesh */ | ||
|
|
||
| #ifndef __AUTHZ_H__ | ||
| #define __AUTHZ_H__ | ||
|
|
||
| #include "workload_common.h" | ||
| #include "bpf_log.h" | ||
| #include "xdp.h" | ||
| #include "workloadapi/security/authorization.pb-c.h" | ||
|
|
||
| #define AUTH_ALLOW 0 | ||
| #define AUTH_DENY 1 | ||
| #define UNMATCHED 0 | ||
| #define MATCHED 1 | ||
|
|
||
| struct { | ||
| __uint(type, BPF_MAP_TYPE_HASH); | ||
| __uint(key_size, sizeof(__u32)); | ||
| __uint(value_size, sizeof(Istio__Security__Authorization)); | ||
| __uint(map_flags, BPF_F_NO_PREALLOC); | ||
| __uint(max_entries, MAP_SIZE_OF_AUTH_POLICY); | ||
| } map_of_authz SEC(".maps"); | ||
|
|
||
| static inline Istio__Security__Authorization *map_lookup_authz(__u32 policyKey) | ||
| { | ||
| return (Istio__Security__Authorization *)kmesh_map_lookup_elem(&map_of_authz, &policyKey); | ||
| } | ||
|
|
||
| static inline wl_policies_v *get_workload_policies_by_uid(__u32 workload_uid) | ||
| { | ||
| return (wl_policies_v *)kmesh_map_lookup_elem(&map_of_wl_policy, &workload_uid); | ||
| } | ||
|
|
||
| static inline int matchDstPorts(Istio__Security__Match *match, struct xdp_info *info, struct bpf_sock_tuple *tuple_info) | ||
| { | ||
| __u32 *notPorts = NULL; | ||
| __u32 *ports = NULL; | ||
| __u32 i; | ||
|
|
||
| if (match->n_destination_ports == 0 && match->n_not_destination_ports == 0) { | ||
| return MATCHED; | ||
| } | ||
|
|
||
| if (match->n_not_destination_ports != 0) { | ||
| notPorts = kmesh_get_ptr_val(match->not_destination_ports); | ||
| if (!notPorts) { | ||
| return UNMATCHED; | ||
| } | ||
| #pragma unroll | ||
| for (i = 0; i < MAX_MEMBER_NUM_PER_POLICY; i++) { | ||
| if (i >= match->n_not_destination_ports) { | ||
| break; | ||
| } | ||
| if (info->iph->version == 4) { | ||
| if (bpf_htons(notPorts[i]) == tuple_info->ipv4.dport) { | ||
| return UNMATCHED; | ||
| } | ||
| } else { | ||
| if (bpf_htons(notPorts[i]) == tuple_info->ipv6.dport) { | ||
| return UNMATCHED; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| // if not match not_destination_ports && has no destination_ports, return MATCHED | ||
| if (match->n_destination_ports == 0) { | ||
| return MATCHED; | ||
| } | ||
|
|
||
| ports = kmesh_get_ptr_val(match->destination_ports); | ||
| if (!ports) { | ||
| return UNMATCHED; | ||
| } | ||
| #pragma unroll | ||
| for (i = 0; i < MAX_MEMBER_NUM_PER_POLICY; i++) { | ||
| if (i >= match->n_destination_ports) { | ||
| break; | ||
| } | ||
| if (info->iph->version == 4) { | ||
| if (bpf_htons(ports[i]) == tuple_info->ipv4.dport) { | ||
| return MATCHED; | ||
| } | ||
| } else { | ||
| if (bpf_htons(ports[i]) == tuple_info->ipv6.dport) { | ||
| return MATCHED; | ||
| } | ||
| } | ||
| } | ||
| return UNMATCHED; | ||
|
There was a problem hiding this comment. If the There was a problem hiding this comment. check the begin of this function， line 42 solved the scenario you mentioned |
||
| } | ||
|
|
||
| static inline int match_check(Istio__Security__Match *match, struct xdp_info *info, struct bpf_sock_tuple *tuple_info) | ||
| { | ||
| __u32 matchResult; | ||
|
|
||
| // if multiple types are set, they are AND-ed, all matched is a match | ||
| // todo: add other match types | ||
| matchResult = matchDstPorts(match, info, tuple_info); | ||
| return matchResult; | ||
| } | ||
|
|
||
| static inline int | ||
| clause_match_check(Istio__Security__Clause *cl, struct xdp_info *info, struct bpf_sock_tuple *tuple_info) | ||
| { | ||
| void *matchsPtr = NULL; | ||
| Istio__Security__Match *match = NULL; | ||
| __u32 i; | ||
|
|
||
| if (cl->n_matches == 0) { | ||
| return UNMATCHED; | ||
| } | ||
| matchsPtr = kmesh_get_ptr_val(cl->matches); | ||
| if (!matchsPtr) { | ||
| return MATCHED; | ||
| } | ||
|
|
||
| #pragma unroll | ||
| for (i = 0; i < MAX_MEMBER_NUM_PER_POLICY; i++) { | ||
| if (i >= cl->n_matches) { | ||
| break; | ||
| } | ||
| match = (Istio__Security__Match *)kmesh_get_ptr_val((void *)*((__u64 *)matchsPtr + i)); | ||
| if (!match) { | ||
| continue; | ||
| } | ||
| // if any match matches, it is a match | ||
| if (match_check(match, info, tuple_info) == MATCHED) { | ||
| return MATCHED; | ||
| } | ||
| } | ||
| return UNMATCHED; | ||
| } | ||
|
|
||
| static inline int | ||
| rule_match_check(Istio__Security__Rule *rule, struct xdp_info *info, struct bpf_sock_tuple *tuple_info) | ||
| { | ||
| void *clausesPtr = NULL; | ||
| Istio__Security__Clause *clause = NULL; | ||
| __u32 i; | ||
|
|
||
| if (rule->n_clauses == 0) { | ||
| BPF_LOG(ERR, AUTH, "rule has no clauses\n"); | ||
| return UNMATCHED; | ||
| } | ||
| // Clauses are AND-ed. | ||
| clausesPtr = kmesh_get_ptr_val(rule->clauses); | ||
| if (!clausesPtr) { | ||
| BPF_LOG(ERR, AUTH, "failed to get clauses from rule\n"); | ||
| return UNMATCHED; | ||
| } | ||
|
|
||
| #pragma unroll | ||
| for (i = 0; i < MAX_MEMBER_NUM_PER_POLICY; i++) { | ||
| if (i >= rule->n_clauses) { | ||
| break; | ||
| } | ||
| clause = (Istio__Security__Clause *)kmesh_get_ptr_val((void *)*((__u64 *)clausesPtr + i)); | ||
| if (!clause) { | ||
| continue; | ||
| } | ||
| if (clause_match_check(clause, info, tuple_info) == UNMATCHED) { | ||
| return UNMATCHED; | ||
| } | ||
| } | ||
| return MATCHED; | ||
| } | ||
|
|
||
| static inline int | ||
| do_auth(Istio__Security__Authorization *policy, struct xdp_info *info, struct bpf_sock_tuple *tuple_info) | ||
| { | ||
| void *rulesPtr = NULL; | ||
| Istio__Security__Rule *rule = NULL; | ||
| int matchFlag = 0; | ||
| __u32 i = 0; | ||
|
|
||
| if (policy->n_rules == 0) { | ||
| BPF_LOG(ERR, AUTH, "auth policy %s has no rules\n", kmesh_get_ptr_val(policy->name)); | ||
| return AUTH_ALLOW; | ||
| } | ||
|
|
||
| // Rules are OR-ed. | ||
| rulesPtr = kmesh_get_ptr_val(policy->rules); | ||
|
There was a problem hiding this comment. I am not familiar with this, but looks weired to me, It is using the ptr address as key, we cannot assume each time the address of a policy is same. Especially when a policy is updated |
||
| if (!rulesPtr) { | ||
| BPF_LOG(ERR, AUTH, "failed to get rules from policy %s\n", kmesh_get_ptr_val(policy->name)); | ||
| return AUTH_DENY; | ||
| } | ||
|
|
||
| for (i = 0; i < MAX_MEMBER_NUM_PER_POLICY; i++) { | ||
| if (i >= policy->n_rules) { | ||
| break; | ||
| } | ||
| rule = (Istio__Security__Rule *)kmesh_get_ptr_val((void *)*((__u64 *)rulesPtr + i)); | ||
| if (!rule) { | ||
| continue; | ||
| } | ||
| if (rule_match_check(rule, info, tuple_info) == MATCHED) { | ||
| if (policy->action == ISTIO__SECURITY__ACTION__DENY) { | ||
| return AUTH_DENY; | ||
| } else { | ||
| return AUTH_ALLOW; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // no match rules | ||
| if (policy->action == ISTIO__SECURITY__ACTION__DENY) { | ||
| return AUTH_ALLOW; | ||
| } else { | ||
| return AUTH_DENY; | ||
| } | ||
| } | ||
|
|
||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does previous /.c already includes workloadapi/security/*.c？
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/.c will only include files in the current directory