-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do rbac in xdp prog #712
do rbac in xdp prog #712
Conversation
f0a231b
to
abec189
Compare
4b284b3
to
00de04e
Compare
/retest |
1 similar comment
/retest |
47cf15d
to
82a01b8
Compare
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
Signed-off-by: superCharge-xsy <[email protected]>
…tart Signed-off-by: superCharge-xsy <[email protected]>
3d14120
to
f83283c
Compare
|
||
ret := C.deserial_init() | ||
if ret != 0 { | ||
l.Stop() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already done in the defer above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a condition in defer action:err !=nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
d842e03
to
7eb35a1
Compare
Signed-off-by: superCharge-xsy <[email protected]>
7eb35a1
to
4c6d933
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nlgwcy defer to you to review the bpf map part
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
can we add a e2e case for it now |
What type of PR is this?
It's a continuation of the previous modification(https://github.com/kmesh-net/kmesh/pull/680)
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #655
Special notes for your reviewer:
Does this PR introduce a user-facing change?: